You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/25 10:30:03 UTC

[GitHub] [incubator-mxnet] PawelGlomski-Intel opened a new pull request #20555: [v1.x][BUGFIX] Export attributes of transformer operators

PawelGlomski-Intel opened a new pull request #20555:
URL: https://github.com/apache/incubator-mxnet/pull/20555


   ## Description ##
   sg_mkldnn_selfatt_qk and sg_mkldnn_selfatt_valatt ops, **when not quantized**, are not exporting their attributes to the \*-symbol.json file, thus making the SymbolBlock.imports/model.load_checkpoint functions crash with an error: "mxnet.base.MXNetError: MXNetError: Required parameter heads of int is not presented, in operator sg_mkldnn_selfatt_\*(name="sg_mkldnn_selfatt_\*")" when trying to load a model that uses them.
   
   This change fixes this issue.
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Assign attributes of transformer operators


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20555: [v1.x][BUGFIX] Export attributes of transformer operators

Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20555:
URL: https://github.com/apache/incubator-mxnet/pull/20555#issuecomment-905379600


   @bgawrych Can you please review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20555: [v1.x][BUGFIX] Export attributes of transformer operators

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20555:
URL: https://github.com/apache/incubator-mxnet/pull/20555#issuecomment-905378718


   Hey @PawelGlomski-Intel , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [centos-cpu, windows-cpu, edge, unix-cpu, sanity, centos-gpu, unix-gpu, windows-gpu, website, miscellaneous, clang]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] akarbown merged pull request #20555: [v1.x][BUGFIX] Export attributes of transformer operators

Posted by GitBox <gi...@apache.org>.
akarbown merged pull request #20555:
URL: https://github.com/apache/incubator-mxnet/pull/20555


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] PawelGlomski-Intel commented on pull request #20555: [v1.x][BUGFIX] Export attributes of transformer operators

Posted by GitBox <gi...@apache.org>.
PawelGlomski-Intel commented on pull request #20555:
URL: https://github.com/apache/incubator-mxnet/pull/20555#issuecomment-906300299


   @akarbown I believe this can be merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org