You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksey Yeschenko (Jira)" <ji...@apache.org> on 2022/11/01 13:47:00 UTC
[jira] [Commented] (CASSANDRA-17768) streaming_keep_alive_period is not used after [CASSANDRA-16927] CEP-10 Phase 1: Refactor Streaming
[ https://issues.apache.org/jira/browse/CASSANDRA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627168#comment-17627168 ]
Aleksey Yeschenko commented on CASSANDRA-17768:
-----------------------------------------------
So here is my current thinking on this, in particular in context of this blocking RC1.
Technically speaking, yes, this is a regression. 4.0 *does* trigger application-level keep-alive at this set interval, and 4.1 no longer does.
In 4.1, {{KeepAliveMessage}} still exists, its handler/serializer logic is still intact. If a 4.1 node receives a {{KeepAliveMessage}}, it won't choke, and handle it just fine. But the code to send these at the configured interval is gone.
I suggest we un-deprecate the param, but set the default to 0, making it opt-in. I also suggest that we bring back the logic to issue these (streaming) roughly as it was originally. That said, I'm not sure this is significant enough to block RC1, given that it can be brought back without any compatibility issue in any minor 4.1 release, whenever we so desire.
> streaming_keep_alive_period is not used after [CASSANDRA-16927] CEP-10 Phase 1: Refactor Streaming
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17768
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17768
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Streaming and Messaging
> Reporter: Ekaterina Dimitrova
> Assignee: Aleksey Yeschenko
> Priority: Normal
> Fix For: 4.1-rc, 4.1.x, 4.x
>
>
> While working on another ticket I noticed that after [CASSANDRA-16927] CEP-10 Phase 1: Refactor Streaming
> streaming_keep_alive_period is not used anymore, except to print it in error message [here|https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/streaming/StreamSession.java#L689]
> If the property should not be used anymore, we need to deprecate it and fix the error message as it is misleading.
> [~benedict] , [~samt] , [~aleksey] , can you, please, check and take care of this one as authors of that patch?
> Thank you in advance!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org