[jira] [Comment Edited] (FALCON-1819) Improve test class entity cleanup logic

["Paul Isaychuk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FALCON-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134184#comment-15134184 ] 

Paul Isaychuk edited comment on FALCON-1819 at 2/5/16 1:44 PM:
---------------------------------------------------------------

I think we just need to figure out what tests set invalid entity names and make respective changes in that tests as they are rather exceptions than common case. Common clean up logic suites well we just need to follow naming convention. 
To not suspend current task as well as FALCON-1784 I would prefer to track it in separate jira. Does that sound good?


was (Author: pisaychuk):
I think we just need to figure out what tests set invalid entity names and make respective changes in that tests as common clean up logic works well. But to not suspend current task as well as FALCON-1784 I would prefer to track it in separate jira. Does that sound good?

> Improve test class entity cleanup logic
> ---------------------------------------
>
>                 Key: FALCON-1819
>                 URL: https://issues.apache.org/jira/browse/FALCON-1819
>             Project: Falcon
>          Issue Type: Bug
>          Components: merlin
>    Affects Versions: 0.7
>            Reporter: Paul Isaychuk
>            Assignee: Paul Isaychuk
>             Fix For: trunk
>
>
> From discussion with Pragya Mittal:
> To got cleaned up, entity should have a name of form like: <prefix> \[entity name itself\]. Where prefix is either test class name or <'A'>+test class name hash code (depending on is_deprecate property from Merlin.properties).
> If entity name is something else, it wouldn't be removed.
> But seems that in case of FeedSubmitAndScheduleTest#snsDiffFeedDiffUserSameCluster feed is not getting deleted not bacause of that. 
> As another user (root) is involved in test case (by submitting feed that belongs to this another user), we don't see that feed in listing feeds as test user (which is used by default to list and remove entities). Makes sense?
> So we need to improve clean up logic to handle entities belonging to different users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)