[GitHub] houshengbo commented on a change in pull request #607: WIP: JSON Output support

[GitBox <gi...@apache.org>]

houshengbo commented on a change in pull request #607: WIP: JSON Output support 
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/607#discussion_r146353673
 
 

 ##########
 File path: parsers/manifest_parser_test.go
 ##########
 @@ -339,15 +324,15 @@ func TestParseManifestForMultiLineParams(t *testing.T) {
 
         // validate outputs
         // output payload is of type string and has a description
-        if payload, ok := action.Outputs["payload"]; ok {
-            p := payload.(map[interface{}]interface{})
-            expectedResult = "string"
-            actualResult = p["type"].(string)
-            assert.Equal(t, expectedResult, actualResult, "Expected " + expectedResult + " but got " + actualResult)
-            expectedResult = "parameter dump"
-            actualResult = p["description"].(string)
-            assert.Equal(t, expectedResult, actualResult, "Expected " + expectedResult + " but got " + actualResult)
-        }
+        //if payload, ok := action.Outputs["payload"]; ok {
 
 Review comment:
   Why do you comment out these lines in this test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services