[GitHub] [incubator-superset] john-bodley commented on pull request #10070: fix: use custom int parsing over flask int parsing in sqllab queries endpoint

[GitBox <gi...@apache.org>]

john-bodley commented on pull request #10070:
URL: https://github.com/apache/incubator-superset/pull/10070#issuecomment-644919341


   @nytai I was lead to believe that [/queries/](https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/SqlLab/components/QueryAutoRefresh.jsx#L71) was always sending an integer, i.e., the timestamp rounded to the nearest millisecond. Would an alternative solution be to update the frontend logic to ensure that it sends an integer? Personally I find that cleaner especially as the backend throws away the fractional millisecond component.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org