You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/14 07:29:44 UTC

[GitHub] [pulsar] Jason918 commented on a change in pull request #14251: [pulsar-broker] provide readable consumer stats time

Jason918 commented on a change in pull request #14251:
URL: https://github.com/apache/pulsar/pull/14251#discussion_r805564175



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/ConsumerStatsImpl.java
##########
@@ -84,7 +85,11 @@
     @JsonIgnore
     private int clientVersionLength;
 
+    // ignore this json field to skip from stats in future release. replaced with readable #getLastAckedTime().
+    @Deprecated

Review comment:
       Is it ok to keep the timestamp? 
   It's useful to calculate time used, like how long since it's last acked.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org