You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/06/13 23:36:13 UTC
Re: Review Request 67561: Refactored `struct Slave` in the allocator
for better performance.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/
-----------------------------------------------------------
(Updated June 13, 2018, 4:36 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till Toenshoff.
Changes
-------
Updated summary. Added benchmark result.
Summary (updated)
-----------------
Refactored `struct Slave` in the allocator for better performance.
Bugs: MESOS-8986
https://issues.apache.org/jira/browse/MESOS-8986
Repository: mesos
Description
-------
This patch refactors the `struct Slave` in the allocator.
In particular, it addresses the slowness of computing
agent's available resources. Instead of calculating it
every time on the fly, this patch "denormalizes" the agent
available resources by updating and persisting the field
each time when agent's allocated or total resources change.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
Diff: https://reviews.apache.org/r/67561/diff/2/
Changes: https://reviews.apache.org/r/67561/diff/1-2/
Testing (updated)
-------
make check
In our simulation environment, we observed 16% allocator performance improvment without quota, and 32% improvment when quota is used.
Thanks,
Meng Zhu
Re: Review Request 67561: Refactored `struct Slave` in the allocator
for better performance.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/
-----------------------------------------------------------
(Updated June 20, 2018, 9:56 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-8986
https://issues.apache.org/jira/browse/MESOS-8986
Repository: mesos
Description
-------
This patch refactors the `struct Slave` in the allocator.
In particular, it addresses the slowness of computing
agent's available resources. Instead of calculating it
every time on the fly, this patch "denormalizes" the agent
available resources by updating and persisting the field
each time when agent's allocated or total resources change.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 19aed2ddfb7d93f3d2a57817a29efc4fd1822ba6
src/master/allocator/mesos/hierarchical.cpp f631ce73d578a313dfdacf1ee97737dde90ae8f8
Diff: https://reviews.apache.org/r/67561/diff/4/
Changes: https://reviews.apache.org/r/67561/diff/3-4/
Testing
-------
make check
In our simulation environment, we observed 16% allocator performance improvment without quota, and 32% improvment when quota is used.
Thanks,
Meng Zhu
Re: Review Request 67561: Refactored `struct Slave` in the allocator
for better performance.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/
-----------------------------------------------------------
(Updated June 19, 2018, 4:21 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till Toenshoff.
Bugs: MESOS-8986
https://issues.apache.org/jira/browse/MESOS-8986
Repository: mesos
Description
-------
This patch refactors the `struct Slave` in the allocator.
In particular, it addresses the slowness of computing
agent's available resources. Instead of calculating it
every time on the fly, this patch "denormalizes" the agent
available resources by updating and persisting the field
each time when agent's allocated or total resources change.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
Diff: https://reviews.apache.org/r/67561/diff/3/
Changes: https://reviews.apache.org/r/67561/diff/2-3/
Testing
-------
make check
In our simulation environment, we observed 16% allocator performance improvment without quota, and 32% improvment when quota is used.
Thanks,
Meng Zhu
Re: Review Request 67561: Refactored `struct Slave` in the allocator
for better performance.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/#review204755
-----------------------------------------------------------
PASS: Mesos patch 67561 was successfully built and tested.
Reviews applied: `['67561']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67561
- Mesos Reviewbot Windows
On June 13, 2018, 11:36 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67561/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 11:36 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till Toenshoff.
>
>
> Bugs: MESOS-8986
> https://issues.apache.org/jira/browse/MESOS-8986
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch refactors the `struct Slave` in the allocator.
> In particular, it addresses the slowness of computing
> agent's available resources. Instead of calculating it
> every time on the fly, this patch "denormalizes" the agent
> available resources by updating and persisting the field
> each time when agent's allocated or total resources change.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
>
>
> Diff: https://reviews.apache.org/r/67561/diff/2/
>
>
> Testing
> -------
>
> make check
>
> In our simulation environment, we observed 16% allocator performance improvment without quota, and 32% improvment when quota is used.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 67561: Refactored `struct Slave` in the allocator
for better performance.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67561/#review204940
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.hpp
Lines 470 (patched)
<https://reviews.apache.org/r/67561/#comment287757>
s/track of slave's/track of the slave's/
- Greg Mann
On June 13, 2018, 11:36 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67561/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 11:36 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, Kapil Arya, and Till Toenshoff.
>
>
> Bugs: MESOS-8986
> https://issues.apache.org/jira/browse/MESOS-8986
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch refactors the `struct Slave` in the allocator.
> In particular, it addresses the slowness of computing
> agent's available resources. Instead of calculating it
> every time on the fly, this patch "denormalizes" the agent
> available resources by updating and persisting the field
> each time when agent's allocated or total resources change.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e9d1742bb35004735e3cb357286b4e5b17436a5c
> src/master/allocator/mesos/hierarchical.cpp b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c
>
>
> Diff: https://reviews.apache.org/r/67561/diff/2/
>
>
> Testing
> -------
>
> make check
>
> In our simulation environment, we observed 16% allocator performance improvment without quota, and 32% improvment when quota is used.
>
>
> Thanks,
>
> Meng Zhu
>
>