You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/09 21:19:10 UTC

[GitHub] [tvm] AndrewZhaoLuo opened a new pull request #8228: [EZ] [Typo] Add a missing override

AndrewZhaoLuo opened a new pull request #8228:
URL: https://github.com/apache/tvm/pull/8228


   Without this, the compiler generates a warning.
   
   cc @mbrookhart 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8228: [EZ] [Typo] Add a missing override

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8228:
URL: https://github.com/apache/tvm/pull/8228#issuecomment-858122312


   I'm on mac so it must be `clang`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #8228: [EZ] [Typo] Add a missing override

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8228:
URL: https://github.com/apache/tvm/pull/8228


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mbrookhart commented on pull request #8228: [EZ] [Typo] Add a missing override

Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #8228:
URL: https://github.com/apache/tvm/pull/8228#issuecomment-858149355


   But which clang? We run both gcc and clang in CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8228: [EZ] [Typo] Add a missing override

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8228:
URL: https://github.com/apache/tvm/pull/8228#issuecomment-858295549


   I'm not entirely sure Matthew. What's the best way for me to check to answer your question?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org