You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/07/30 20:09:43 UTC
Review Request 36947: Fix new/delete mismatch in stout test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36947/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
Bugs: MESOS-3175
https://issues.apache.org/jira/browse/MESOS-3175
Repository: mesos
Description
-------
Fix new/delete mismatch in stout test.
Diffs
-----
3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4
Diff: https://reviews.apache.org/r/36947/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett
Re: Review Request 36947: Fix new/delete mismatch in stout test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36947/#review93619
-----------------------------------------------------------
Ship it!
Note that subprocess is in libprocess rather than stout :)
- Ben Mahler
On July 30, 2015, 6:09 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36947/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 6:09 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3175
> https://issues.apache.org/jira/browse/MESOS-3175
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix new/delete mismatch in stout test.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4
>
> Diff: https://reviews.apache.org/r/36947/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36947: Fix new/delete mismatch in stout test.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36947/#review93622
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36947]
All tests passed.
- Mesos ReviewBot
On July 30, 2015, 6:09 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36947/
> -----------------------------------------------------------
>
> (Updated July 30, 2015, 6:09 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3175
> https://issues.apache.org/jira/browse/MESOS-3175
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix new/delete mismatch in stout test.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp f6acb204582a9e696c3b09d4e4c543bb052e97d4
>
> Diff: https://reviews.apache.org/r/36947/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>