You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/01/23 09:08:16 UTC
[GitHub] [dubbo] AlbumenJ commented on a change in pull request #9613: Fix forking npe
AlbumenJ commented on a change in pull request #9613:
URL: https://github.com/apache/dubbo/pull/9613#discussion_r790247722
##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvoker.java
##########
@@ -96,7 +93,7 @@ public Result doInvoke(final Invocation invocation, List<Invoker<T>> invokers, L
});
}
try {
- Object ret = ref.poll(timeout, TimeUnit.MILLISECONDS);
+ Object ret = ref.poll(Integer.MAX_VALUE, TimeUnit.MILLISECONDS);
Review comment:
What is the purpose change this line? Will this cause NPE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org