You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/01/23 20:21:16 UTC
[I] Additional `IN` / `NOT IN` simplifications [arrow-datafusion]
alamb opened a new issue, #8970:
URL: https://github.com/apache/arrow-datafusion/issues/8970
In the following on PR, I think we can move inlist related simplifier logic to `inlist_simplifier`.
Steps in inlist_simplifier
1. early stage simplification like `expr IN () --> false`, `null IN/NOT IN`
2. convert long OR chain or AND chain to InList expressions like what `or_in_list_simplifier` does
3. shorten InList expressions like what `inlist_simplifier` in this PR does
4. convert final inlist to OR chain or AND chain if len < 3. Move inlist related simplifier out from `expr_simplifier`
In this way, when the logic grows more complex, we can easily find out related conversion about specific Expr
_Originally posted by @jayzhan211 in https://github.com/apache/arrow-datafusion/issues/8949#issuecomment-1906115890_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Additional `IN` / `NOT IN` simplifications [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8970:
URL: https://github.com/apache/arrow-datafusion/issues/8970#issuecomment-1907943251
I think this issue might be done best in multiple PRs
SO for example the first PR could just move all the inlist related simplifications into one place
Note I also have a PR to change the code, for your awareness: https://github.com/apache/arrow-datafusion/pull/8971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Additional `IN` / `NOT IN` simplifications [arrow-datafusion]
Posted by "guojidan (via GitHub)" <gi...@apache.org>.
guojidan commented on issue #8970:
URL: https://github.com/apache/arrow-datafusion/issues/8970#issuecomment-1909270453
tasks:
- [ ] early stage simplification like expr IN () --> false, null IN/NOT IN
- [ ] convert long OR chain or AND chain to InList expressions like what or_in_list_simplifier does
- [ ] shorten InList expressions like what inlist_simplifier in this PR does
- [ ] convert final inlist to OR chain or AND chain if len < 3. Move inlist related simplifier out from expr_simplifier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Additional `IN` / `NOT IN` simplifications [arrow-datafusion]
Posted by "guojidan (via GitHub)" <gi...@apache.org>.
guojidan commented on issue #8970:
URL: https://github.com/apache/arrow-datafusion/issues/8970#issuecomment-1907867614
I am interested in this and let me try to implement it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Additional `IN` / `NOT IN` simplifications [arrow-datafusion]
Posted by "guojidan (via GitHub)" <gi...@apache.org>.
guojidan commented on issue #8970:
URL: https://github.com/apache/arrow-datafusion/issues/8970#issuecomment-1907947821
ok, I got it 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org