[GitHub] nifi-minifi-cpp pull request #188: MINIFICPP-49 Added initial implementation...

[phrocker <gi...@git.apache.org>]

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/188#discussion_r154381712
  
    --- Diff: libminifi/CMakeLists.txt ---
    @@ -74,6 +74,7 @@ target_link_libraries(core-minifi ${UUID_LIBRARIES} ${JSONCPP_LIB} yaml-cpp )
     find_package(ZLIB REQUIRED)
     include_directories(${ZLIB_INCLUDE_DIRS})
     
    +target_link_libraries(core-minifi minifi-expression-language-extensions)
    --- End diff --
    
    Should be able to use enable_if to to completely eliminate the code and the function calls, but I'm not terribly worried. Cost will be low and can be changed in the future. 
    
    It won't be completely optimized. With -O3 you'll get a stack setup, checks for the std::__throw_bad_function_call() and delete in the assembler. It's not the same as calling an empty function that does nothing, which can be optimized out, but in my opinion it's premature to concern ourselves over the cost. 


---