You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/08/10 08:19:27 UTC
Re: Review Request 72727: Updated the test CSI plugin for CSI server
testing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72727/#review221524
-----------------------------------------------------------
src/examples/test_csi_plugin.cpp
Lines 232-235 (original), 249-254 (patched)
<https://reviews.apache.org/r/72727/#comment310574>
It seems when `volumeIdPath` is set to `false` we will call `mkdir` to create directory for the volume under the current working directory? But I think we should create it under `TestCSIPlugin::workDir` just like what we did when `volumeIdPath` is set to `true`.
- Qian Zhang
On Aug. 1, 2020, 3:06 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72727/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2020, 3:06 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds additional configuration flags to the
> test CSI plugin which are necessary in order to test
> the agent's CSI server.
>
>
> Diffs
> -----
>
> src/examples/test_csi_plugin.cpp 6202173844a93b8d9642208bd86839b3cf56bce2
>
>
> Diff: https://reviews.apache.org/r/72727/diff/1/
>
>
> Testing
> -------
>
> These new flags are used in a subsequent test in this chain.
>
>
> Thanks,
>
> Greg Mann
>
>