You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (Assigned) (JIRA)" <ji...@apache.org> on 2011/12/19 04:58:30 UTC

[jira] [Assigned] (TS-1055) Wrong implementation of TSHttpSsnArgGet

     [ https://issues.apache.org/jira/browse/TS-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom reassigned TS-1055:
---------------------------------

    Assignee: Leif Hedstrom
    
> Wrong implementation of TSHttpSsnArgGet
> ---------------------------------------
>
>                 Key: TS-1055
>                 URL: https://issues.apache.org/jira/browse/TS-1055
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>    Affects Versions: 3.1.1
>            Reporter: Yakov Kopel
>            Assignee: Leif Hedstrom
>              Labels: api-change
>             Fix For: 3.1.2
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is a different between the interface of TSHttpSsnArgGet and it implemenation.
> In the interface (proxy/api/ts/ts.h.in):
>      tsapi void* TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx);
> In the implementation(proxy/InkAPI.cc):
>       void * TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> So, I wrote a simple patch to fix this problem:
> Index: InkAPI.cc
> ===================================================================
> --- InkAPI.cc   (revision 1220421)
> +++ InkAPI.cc   (working copy)
> @@ -5500,7 +5500,7 @@
>  }
>  void *
> -TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx, void **argp)
> +TSHttpSsnArgGet(TSHttpSsn ssnp, int arg_idx)
>  {
>    sdk_assert(sdk_sanity_check_http_ssn(ssnp) == TS_SUCCESS);
>    sdk_assert(arg_idx >= 0 && arg_idx < HTTP_SSN_TXN_MAX_USER_ARG);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira