You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/08/01 15:44:42 UTC
[GitHub] [camel-k-examples] gansheer opened a new pull request, #84: feat(config): User configuration examples
gansheer opened a new pull request, #84:
URL: https://github.com/apache/camel-k-examples/pull/84
* Update existing user configuration examples
* Add kamelets configuration examples
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] squakez merged pull request #84: feat(config): User configuration examples
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #84:
URL: https://github.com/apache/camel-k-examples/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] gansheer commented on a diff in pull request #84: feat(config): User configuration examples
Posted by "gansheer (via GitHub)" <gi...@apache.org>.
gansheer commented on code in PR #84:
URL: https://github.com/apache/camel-k-examples/pull/84#discussion_r1280862766
##########
generic-examples/kamelets/README.md:
##########
@@ -26,4 +26,7 @@ The examples are grouped into the following sub-directories:
- [timer-source-log-sink](./timer-source-log-sink/):
- create and use a timer source kamelet
- bind a source kamelet to a Knative destination using KamletBinding
- - create a log sink kamlet and bind it to the Knative destination using KamletBinding
\ No newline at end of file
+ - create a log sink kamlet and bind it to the Knative destination using KamletBinding
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] squakez commented on a diff in pull request #84: feat(config): User configuration examples
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #84:
URL: https://github.com/apache/camel-k-examples/pull/84#discussion_r1280836306
##########
generic-examples/kamelets/README.md:
##########
@@ -26,4 +26,7 @@ The examples are grouped into the following sub-directories:
- [timer-source-log-sink](./timer-source-log-sink/):
- create and use a timer source kamelet
- bind a source kamelet to a Knative destination using KamletBinding
- - create a log sink kamlet and bind it to the Knative destination using KamletBinding
\ No newline at end of file
+ - create a log sink kamlet and bind it to the Knative destination using KamletBinding
Review Comment:
```suggestion
- create a log sink kamelet and bind it to the Knative destination using KameletBinding/Pipe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org