You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/20 00:48:20 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #5219: [TEST] Test unit - Fix failing UI unit test 4.15 branch
utchoang opened a new pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219
### Description
Related https://github.com/apache/cloudstack/issues/5212
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-886369257
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883020101
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678813114
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
@davidjumani If I don't set the originalPage it will be null, when I run the test, I get the following error. It seems that `options.originalPage = options.originalPage || this.$router.currentRoute.path` it doesn't override originalPage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883017400
UI build: :heavy_multiplication_x:
(SL-JID-387)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani merged pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani merged pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678210427
##########
File path: ui/src/utils/plugins.js
##########
@@ -64,7 +64,7 @@ export const pollJobPlugin = {
status: 'progress'
})
- options.originalPage = options.originalPage ? options.originalPage : this.$router.currentRoute.path
+ const originalPageOpts = originalPage || this.$router.currentRoute.path
Review comment:
```suggestion
const originalPageOpts = options.originalPage || this.$router.currentRoute.path
```
##########
File path: ui/src/utils/plugins.js
##########
@@ -64,7 +64,7 @@ export const pollJobPlugin = {
status: 'progress'
})
- options.originalPage = options.originalPage ? options.originalPage : this.$router.currentRoute.path
+ const originalPageOpts = originalPage || this.$router.currentRoute.path
Review comment:
```suggestion
const originalPageOpts = options.originalPage || this.$router.currentRoute.path
```
##########
File path: ui/src/utils/plugins.js
##########
@@ -64,7 +64,7 @@ export const pollJobPlugin = {
status: 'progress'
})
- options.originalPage = options.originalPage ? options.originalPage : this.$router.currentRoute.path
+ const originalPageOpts = originalPage || this.$router.currentRoute.path
Review comment:
@utchoang It should remain `options.originalPage` since that is passed when calling the async job again
```suggestion
options.originalPage = options.originalPage || this.$router.currentRoute.path
```
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = originalPageOpts === currentPage || originalPageOpts.startsWith(currentPage + '/')
Review comment:
```suggestion
const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678817325
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
@davidjumani
What do you think about my suggestion?
`const originalPagePath = originalPage || this.$router.currentRoute.path`
and
`const samePage = originalPagePath === currentPage || originalPagePath.startsWith(currentPage + '/')`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r679640231
##########
File path: ui/src/utils/plugins.js
##########
@@ -64,7 +64,8 @@ export const pollJobPlugin = {
status: 'progress'
})
- options.originalPage = options.originalPage ? options.originalPage : this.$router.currentRoute.path
+ const originalPageReceive = originalPage || this.$router.currentRoute.path
Review comment:
```suggestion
const originalPageReceive = options.originalPage || this.$router.currentRoute.path
```
Can remove `originalPage = null` on 57
This way it will refresh only on the current / parent page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-889731997
@utchoang Can you merge this into main and fix failures on main? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678813621
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
if queryAsync JobResult has response job status = 1 (not equals 0) originalPage is null, and can't use startsWith of null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-889767266
@utchoang I've forward merged the conflicts on main, any new changes/fixes should be done in the other PR - https://github.com/apache/cloudstack/pull/5220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678811874
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
```suggestion
const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
```
My bad @utchoang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678813621
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
originalPage is null, and can't startsWith by this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-888785633
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-888847107
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678813621
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
if queryAsync JobResult has response jobstatus = 1 (not equals 0) originalPage is null, and can't use startsWith of null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-889691472
```
PASS tests/unit/components/view/ActionButton.spec.js
PASS tests/unit/components/widgets/Status.spec.js
PASS tests/unit/views/compute/MigrateWizard.spec.js
PASS tests/unit/views/AutogenView.spec.js (9.027s)
=============================== Coverage summary ===============================
Statements : 4.91% ( 760/15477 )
Branches : 5.99% ( 470/7850 )
Functions : 2.68% ( 136/5083 )
Lines : 4.9% ( 754/15386 )
================================================================================
Test Suites: 4 passed, 4 total
Tests: 134 passed, 134 total
Snapshots: 0 total
Time: 17.228s
Ran all test suites.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-886371083
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5219 (SL-JID-421)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678817325
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
@davidjumani
What do you think about my suggestion?
`const originalPagePath = originalPage || this.$router.currentRoute.path`
and
`const samePage = originalPagePath === currentPage || originalPagePath.startsWith(currentPage + '/')`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883020274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883020274
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015503
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015503
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015583
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-889677969
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-889681440
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5219 (SL-JID-449)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-888787280
UI build: :heavy_multiplication_x:
(SL-JID-443)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883020101
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-888847563
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678813621
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
originalPage is null, and can't use startsWith by this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883022245
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5219 (SL-JID-388)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678904382
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
Got it! Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-886369455
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-888785304
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-887236161
I've checked the code, but tests are passing per Travis:
```
> cloudstack-ui@1.0.0 lint /home/travis/build/apache/cloudstack/ui
> vue-cli-service lint
DONE No lint errors found!
> cloudstack-ui@1.0.0 test:unit /home/travis/build/apache/cloudstack/ui
> vue-cli-service test:unit
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
[vue-jest]: Less are not currently compiled by vue-jest
PASS tests/unit/views/AutogenView.spec.js (21.07s)
PASS tests/unit/views/compute/MigrateWizard.spec.js
PASS tests/unit/components/widgets/Status.spec.js
PASS tests/unit/components/view/ActionButton.spec.js
=============================== Coverage summary ===============================
Statements : 4.92% ( 759/15419 )
Branches : 6% ( 470/7834 )
Functions : 2.69% ( 136/5063 )
Lines : 4.91% ( 753/15328 )
================================================================================
Test Suites: 4 passed, 4 total
Tests: 134 passed, 134 total
Snapshots: 0 total
Time: 77.768s
Ran all test suites.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-888849513
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5219 (SL-JID-444)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-889678368
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015503
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678817325
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
What do you think about my suggestion?
`const originalPagePath = originalPage || this.$router.currentRoute.path`
and
`const samePage = originalPagePath === currentPage || originalPagePath.startsWith(currentPage + '/')`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on a change in pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#discussion_r678813621
##########
File path: ui/src/utils/plugins.js
##########
@@ -90,7 +90,7 @@ export const pollJobPlugin = {
// Ensure we refresh on the same / parent page
const currentPage = this.$router.currentRoute.path
- const samePage = originalPage === currentPage || originalPage.startsWith(currentPage + '/')
+ const samePage = options.originalPage === currentPage || options.originalPage.startsWith(currentPage + '/')
Review comment:
if queryAsync JobResult has response job status = 1 (not equals 0) originalPage is null, and can't use startsWith by this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #5219: [TEST] - Test unit - Fix failing UI unit test 4.15 branch
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #5219:
URL: https://github.com/apache/cloudstack/pull/5219#issuecomment-883015503
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org