You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sravan-s <gi...@git.apache.org> on 2018/01/20 08:07:40 UTC

[GitHub] zeppelin pull request #2735: [JIRA-DOWN]Resize charts on paragaph resize

GitHub user sravan-s opened a pull request:

    https://github.com/apache/zeppelin/pull/2735

    [JIRA-DOWN]Resize charts on paragaph resize

    ### What is this PR for?
    Resize charts on paragraph resize
    
    * Broadcast chart resize on para. resize with a timeout
    * Add warning on refresh missing
    
    ### What type of PR is it?
    [Bug Fix | Improvement]
    
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
    
    ### How should this be tested?
    
    Open a paragraph with charts and resize paragraph width(see the gif)
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? N
    * Is there breaking changes for older versions? N 
    * Does this needs documentation? N


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sravan-s/zeppelin fix/resize-chart

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2735
    
----
commit 9bf9894962210d95e8aada74ea7184e86920b043
Author: sravan <sr...@...>
Date:   2018-01-20T07:08:14Z

    Resize charts on paragraph resize
    
    * Broadcast chart resize on para. resize with timeout
    * Add warning on refresh missing

----


---

[GitHub] zeppelin issue #2735: [ZEPPELIN-3177]Resize charts on paragaph resize

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2735
  
    ping @felixcheung 


---

[GitHub] zeppelin issue #2735: [ZEPPELIN-3177]Resize charts on paragaph resize

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2735
  
    Hey guys, anyone here :) ?


---

[GitHub] zeppelin pull request #2735: [ZEPPELIN-3177]Resize charts on paragaph resize

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2735


---

[GitHub] zeppelin issue #2735: [JIRA-DOWN]Resize charts on paragaph resize

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2735
  
    Before:
    ![zeppelin3](https://user-images.githubusercontent.com/11382805/35181391-63e361ca-fe04-11e7-9e47-f07a154b65c6.gif)
    
    After:
    ![zeppelin3](https://user-images.githubusercontent.com/11382805/35181425-9623d962-fe04-11e7-8660-8dc82c54cd0e.gif)
    



---

[GitHub] zeppelin issue #2735: [ZEPPELIN-3177]Resize charts on paragaph resize

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2735
  
    Tested and it works well.
    
    LGTM and merge to master and branch-0.8.


---

[GitHub] zeppelin issue #2735: [JIRA-DOWN]Resize charts on paragaph resize

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2735
  
    Nb. I am waiting for JIRA. It's down for me
    



---