Re: svn commit: r169535 - /httpd/httpd/branches/1.3.x/src/modules/standard/mod_log_forensic.c

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

At 06:36 PM 5/10/2005, wrowe@apache.org wrote:

>  Win32-enable, unix threaded-enable the mod_log_forensic module.
>
>  * adds a get_forensic_id() function, differing between win32,
>    threaded, and non-threaded platforms (threaded and win32
>    platforms get instead an pid:tid:time:seq identifier.)
>
>  * stop the module config abuse, and simply use r->notes (this
>    requires the 169534 svn patch already applied.)

I'm very interested for someone(s) to verify that

 . it works on netware?

 . builds and the old tid:time:pid format is good still on unix.

Bill  

Re: svn commit: r169535 - /httpd/httpd/branches/1.3.x/src/modules/standard/mod_log_forensic.c

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

At 11:51 PM 5/10/2005, André Malo wrote:
>>
>>  . builds and the old tid:time:pid format is good still on unix.
>
>What happend to the good ol' RTC?

<shrug> happy to revert it.  mod_log_forensic certainly isn't in
the --modules-most list - and was a typical example of an explicitly
thread-unsafe module.  (statics that never needed to be static?  grumf.)
I considered this a platform patch from the moment I converted it.

I had actually written logic (long gone now after two pool rewrites
to APR) which explicitly made the pool memory associated with conf
data read-only (to the point of segfaulting the server if the
contract was violated.)  Essentially 1) it's bad practice and 2) 99%
of the time it's an actual bug.

Actually I presumed one of the five people on this list that still
bother to test 1.3 on a regular basis would comment fairly quickly.

I do have a second patch (in just a moment) which applies to the
core, which I intended for R-T-C from the get-go.  It's a cool idea,
not a must-have-to-build.

Bill

Re: svn commit: r169535 - /httpd/httpd/branches/1.3.x/src/modules/standard/mod_log_forensic.c

[André Malo <nd...@perlig.de>]

* William A. Rowe, Jr. wrote:

Thanks for catching that, but...

> I'm very interested for someone(s) to verify that
>
>  . it works on netware?
>
>  . builds and the old tid:time:pid format is good still on unix.

What happend to the good ol' RTC?

nd
-- 
Wenn nur Ingenieure mit Diplom programmieren würden, hätten wir
wahrscheinlich weniger schlechte Software.
Wir hätten allerdings auch weniger gute Software.
                                   -- Felix von Leitner in dasr