[jira] [Commented] (SOLR-9412) Update Macro Expander for replacement logic

["Christine Poerschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428298#comment-15428298 ] 

Christine Poerschke commented on SOLR-9412:
-------------------------------------------

re: the random(ized) elements in the test and LuceneTestCase, [~dweiss]'s [talk|https://www.youtube.com/watch?v=-uVE_w8flIU] at [Berlin Buzzwords|https://berlinbuzzwords.de/session/randomize-your-tests-and-it-will-blow-your-socks] is a good intro to the concept etc.

> Update Macro Expander for replacement logic
> -------------------------------------------
>
>                 Key: SOLR-9412
>                 URL: https://issues.apache.org/jira/browse/SOLR-9412
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Jon Dorando
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9412.patch, test_macro_expander.patch
>
>
> MacroExpander class was updated to allow to return null when replacement parameters are missing. Right now it defaults to a blank space and it isn't easily verifiable that a parameter was missing. Additionally, unit tests were added for this case and the original use cases of Macro Expander.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org