You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/09/25 17:38:41 UTC

[orc] branch main updated: ORC-1007: Fix a warning from the shade plugin (#916)

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new 6da96bb  ORC-1007: Fix a warning from the shade plugin (#916)
6da96bb is described below

commit 6da96bb8ceb64528d082974efed411c4c29f3408
Author: Guiyanakaung <gu...@gmail.com>
AuthorDate: Sun Sep 26 01:38:33 2021 +0800

    ORC-1007: Fix a warning from the shade plugin (#916)
    
    ### What changes were proposed in this pull request?
    
    Filtering module-info.class file during build of uber.jar
    Fix the warning.
    ```
    Warning:  Discovered module-info.class. Shading will break its strong encapsulation.
    Warning:  Discovered module-info.class. Shading will break its strong encapsulation.
    Warning:  Discovered module-info.class. Shading will break its strong encapsulation.
    ```
    
    ### Why are the changes needed?
    
    I don't think the module system makes sense for uber.jar, it's useful during development. The module-info.class of multiple modules will override each other during the build of uber.jar, and I think its strong encapsulation may have an effect on uber.jar.
    
    ### How was this patch tested?
    
    Pass the CIs.
---
 java/bench/spark/pom.xml | 1 +
 java/pom.xml             | 1 +
 2 files changed, 2 insertions(+)

diff --git a/java/bench/spark/pom.xml b/java/bench/spark/pom.xml
index 6cec534..6e5146b 100644
--- a/java/bench/spark/pom.xml
+++ b/java/bench/spark/pom.xml
@@ -178,6 +178,7 @@
                 <filter>
                   <artifact>*:*</artifact>
                   <excludes>
+                    <exclude>module-info.class</exclude>
                     <exclude>META-INF/MANIFEST.MF</exclude>
                     <exclude>META-INF/DEPENDENCIES</exclude>
                     <exclude>META-INF/LICENSE</exclude>
diff --git a/java/pom.xml b/java/pom.xml
index 468a4e6..cf71bf8 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -393,6 +393,7 @@
                   <filter>
                     <artifact>*:*</artifact>
                     <excludes>
+                      <exclude>module-info.class</exclude>
                       <exclude>META-INF/MANIFEST.MF</exclude>
                       <exclude>META-INF/DEPENDENCIES</exclude>
                       <exclude>META-INF/LICENSE</exclude>