You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by mi...@apache.org on 2015/11/11 03:24:23 UTC

[17/52] [partial] hbase git commit: Published website at 40c7b09ac86bdbf560321fa71867112aea92a324

http://git-wip-us.apache.org/repos/asf/hbase/blob/1619ae4c/testdevapidocs/src-html/org/apache/hadoop/hbase/client/TestMetaWithReplicas.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/client/TestMetaWithReplicas.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/client/TestMetaWithReplicas.html
index 3c5f66e..baee385 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/client/TestMetaWithReplicas.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/client/TestMetaWithReplicas.html
@@ -178,292 +178,296 @@
 <span class="sourceLineNo">170</span>      util.getHBaseAdmin().disableTable(TABLE);<a name="line.170"></a>
 <span class="sourceLineNo">171</span>      util.getHBaseAdmin().deleteTable(TABLE);<a name="line.171"></a>
 <span class="sourceLineNo">172</span>    }<a name="line.172"></a>
-<span class="sourceLineNo">173</span>    Table htable = util.createTable(TABLE, FAMILIES);<a name="line.173"></a>
-<span class="sourceLineNo">174</span><a name="line.174"></a>
-<span class="sourceLineNo">175</span>    util.getHBaseAdmin().flush(TableName.META_TABLE_NAME);<a name="line.175"></a>
-<span class="sourceLineNo">176</span>    Thread.sleep(conf.getInt(StorefileRefresherChore.REGIONSERVER_STOREFILE_REFRESH_PERIOD,<a name="line.176"></a>
-<span class="sourceLineNo">177</span>       30000) * 6);<a name="line.177"></a>
-<span class="sourceLineNo">178</span>    Connection c = ConnectionFactory.createConnection(util.getConfiguration());<a name="line.178"></a>
-<span class="sourceLineNo">179</span>    List&lt;HRegionInfo&gt; regions = MetaTableAccessor.getTableRegions(c, TABLE);<a name="line.179"></a>
-<span class="sourceLineNo">180</span>    HRegionLocation hrl = MetaTableAccessor.getRegionLocation(c, regions.get(0));<a name="line.180"></a>
-<span class="sourceLineNo">181</span>    // Ensure that the primary server for test table is not the same one as the primary<a name="line.181"></a>
-<span class="sourceLineNo">182</span>    // of the meta region since we will be killing the srv holding the meta's primary...<a name="line.182"></a>
-<span class="sourceLineNo">183</span>    // We want to be able to write to the test table even when the meta is not present ..<a name="line.183"></a>
-<span class="sourceLineNo">184</span>    // If the servers are the same, then move the test table's region out of the server<a name="line.184"></a>
-<span class="sourceLineNo">185</span>    // to another random server<a name="line.185"></a>
-<span class="sourceLineNo">186</span>    if (hrl.getServerName().equals(primary)) {<a name="line.186"></a>
-<span class="sourceLineNo">187</span>      util.getHBaseAdmin().move(hrl.getRegionInfo().getEncodedNameAsBytes(), null);<a name="line.187"></a>
-<span class="sourceLineNo">188</span>      // wait for the move to complete<a name="line.188"></a>
-<span class="sourceLineNo">189</span>      do {<a name="line.189"></a>
-<span class="sourceLineNo">190</span>        Thread.sleep(10);<a name="line.190"></a>
-<span class="sourceLineNo">191</span>        hrl = MetaTableAccessor.getRegionLocation(c, regions.get(0));<a name="line.191"></a>
-<span class="sourceLineNo">192</span>      } while (primary.equals(hrl.getServerName()));<a name="line.192"></a>
-<span class="sourceLineNo">193</span>      util.getHBaseAdmin().flush(TableName.META_TABLE_NAME);<a name="line.193"></a>
-<span class="sourceLineNo">194</span>      Thread.sleep(conf.getInt(StorefileRefresherChore.REGIONSERVER_STOREFILE_REFRESH_PERIOD,<a name="line.194"></a>
-<span class="sourceLineNo">195</span>         30000) * 3);<a name="line.195"></a>
-<span class="sourceLineNo">196</span>    }<a name="line.196"></a>
-<span class="sourceLineNo">197</span>    ServerName master = util.getHBaseClusterInterface().getClusterStatus().getMaster();<a name="line.197"></a>
-<span class="sourceLineNo">198</span>    // kill the master so that regionserver recovery is not triggered at all<a name="line.198"></a>
-<span class="sourceLineNo">199</span>    // for the meta server<a name="line.199"></a>
-<span class="sourceLineNo">200</span>    util.getHBaseClusterInterface().stopMaster(master);<a name="line.200"></a>
-<span class="sourceLineNo">201</span>    util.getHBaseClusterInterface().waitForMasterToStop(master, 60000);<a name="line.201"></a>
-<span class="sourceLineNo">202</span>    if (!master.equals(primary)) {<a name="line.202"></a>
-<span class="sourceLineNo">203</span>      util.getHBaseClusterInterface().killRegionServer(primary);<a name="line.203"></a>
-<span class="sourceLineNo">204</span>      util.getHBaseClusterInterface().waitForRegionServerToStop(primary, 60000);<a name="line.204"></a>
-<span class="sourceLineNo">205</span>    }<a name="line.205"></a>
-<span class="sourceLineNo">206</span>    ((ClusterConnection)c).clearRegionCache();<a name="line.206"></a>
-<span class="sourceLineNo">207</span>    htable.close();<a name="line.207"></a>
-<span class="sourceLineNo">208</span>    htable = c.getTable(TABLE);<a name="line.208"></a>
-<span class="sourceLineNo">209</span>    byte[] row = "test".getBytes();<a name="line.209"></a>
-<span class="sourceLineNo">210</span>    Put put = new Put(row);<a name="line.210"></a>
-<span class="sourceLineNo">211</span>    put.addColumn("foo".getBytes(), row, row);<a name="line.211"></a>
-<span class="sourceLineNo">212</span>    BufferedMutator m = c.getBufferedMutator(TABLE);<a name="line.212"></a>
-<span class="sourceLineNo">213</span>    m.mutate(put);<a name="line.213"></a>
-<span class="sourceLineNo">214</span>    m.flush();<a name="line.214"></a>
-<span class="sourceLineNo">215</span>    // Try to do a get of the row that was just put<a name="line.215"></a>
-<span class="sourceLineNo">216</span>    Get get = new Get(row);<a name="line.216"></a>
-<span class="sourceLineNo">217</span>    Result r = htable.get(get);<a name="line.217"></a>
-<span class="sourceLineNo">218</span>    assertTrue(Arrays.equals(r.getRow(), row));<a name="line.218"></a>
-<span class="sourceLineNo">219</span>    // now start back the killed servers and disable use of replicas. That would mean<a name="line.219"></a>
-<span class="sourceLineNo">220</span>    // calls go to the primary<a name="line.220"></a>
-<span class="sourceLineNo">221</span>    util.getHBaseClusterInterface().startMaster(master.getHostname(), 0);<a name="line.221"></a>
-<span class="sourceLineNo">222</span>    util.getHBaseClusterInterface().startRegionServer(primary.getHostname(), 0);<a name="line.222"></a>
-<span class="sourceLineNo">223</span>    util.getHBaseClusterInterface().waitForActiveAndReadyMaster();<a name="line.223"></a>
-<span class="sourceLineNo">224</span>    ((ClusterConnection)c).clearRegionCache();<a name="line.224"></a>
-<span class="sourceLineNo">225</span>    htable.close();<a name="line.225"></a>
-<span class="sourceLineNo">226</span>    conf.setBoolean(HConstants.USE_META_REPLICAS, false);<a name="line.226"></a>
-<span class="sourceLineNo">227</span>    htable = c.getTable(TABLE);<a name="line.227"></a>
-<span class="sourceLineNo">228</span>    r = htable.get(get);<a name="line.228"></a>
-<span class="sourceLineNo">229</span>    assertTrue(Arrays.equals(r.getRow(), row));<a name="line.229"></a>
-<span class="sourceLineNo">230</span>  }<a name="line.230"></a>
-<span class="sourceLineNo">231</span><a name="line.231"></a>
-<span class="sourceLineNo">232</span>  @Test<a name="line.232"></a>
-<span class="sourceLineNo">233</span>  public void testMetaLookupThreadPoolCreated() throws Exception {<a name="line.233"></a>
-<span class="sourceLineNo">234</span>    TableName TABLE = TableName.valueOf("testMetaLookupThreadPoolCreated");<a name="line.234"></a>
-<span class="sourceLineNo">235</span>    byte[][] FAMILIES = new byte[][] { Bytes.toBytes("foo") };<a name="line.235"></a>
-<span class="sourceLineNo">236</span>    if (TEST_UTIL.getHBaseAdmin().tableExists(TABLE)) {<a name="line.236"></a>
-<span class="sourceLineNo">237</span>      TEST_UTIL.getHBaseAdmin().disableTable(TABLE);<a name="line.237"></a>
-<span class="sourceLineNo">238</span>      TEST_UTIL.getHBaseAdmin().deleteTable(TABLE);<a name="line.238"></a>
-<span class="sourceLineNo">239</span>    }<a name="line.239"></a>
-<span class="sourceLineNo">240</span>    Table htable = TEST_UTIL.createTable(TABLE, FAMILIES);<a name="line.240"></a>
-<span class="sourceLineNo">241</span>    byte[] row = "test".getBytes();<a name="line.241"></a>
-<span class="sourceLineNo">242</span>    ConnectionImplementation c = ((ConnectionImplementation) TEST_UTIL.getConnection());<a name="line.242"></a>
-<span class="sourceLineNo">243</span>    // check that metalookup pool would get created<a name="line.243"></a>
-<span class="sourceLineNo">244</span>    c.relocateRegion(TABLE, row);<a name="line.244"></a>
-<span class="sourceLineNo">245</span>    ExecutorService ex = c.getCurrentMetaLookupPool();<a name="line.245"></a>
-<span class="sourceLineNo">246</span>    assert(ex != null);<a name="line.246"></a>
-<span class="sourceLineNo">247</span>  }<a name="line.247"></a>
-<span class="sourceLineNo">248</span><a name="line.248"></a>
-<span class="sourceLineNo">249</span>  @Test<a name="line.249"></a>
-<span class="sourceLineNo">250</span>  public void testChangingReplicaCount() throws Exception {<a name="line.250"></a>
-<span class="sourceLineNo">251</span>    // tests changing the replica count across master restarts<a name="line.251"></a>
-<span class="sourceLineNo">252</span>    // reduce the replica count from 3 to 2<a name="line.252"></a>
-<span class="sourceLineNo">253</span>    stopMasterAndValidateReplicaCount(3, 2);<a name="line.253"></a>
-<span class="sourceLineNo">254</span>    // increase the replica count from 2 to 3<a name="line.254"></a>
-<span class="sourceLineNo">255</span>    stopMasterAndValidateReplicaCount(2, 3);<a name="line.255"></a>
-<span class="sourceLineNo">256</span>  }<a name="line.256"></a>
-<span class="sourceLineNo">257</span><a name="line.257"></a>
-<span class="sourceLineNo">258</span>  private void stopMasterAndValidateReplicaCount(final int originalReplicaCount,<a name="line.258"></a>
-<span class="sourceLineNo">259</span>      final int newReplicaCount)<a name="line.259"></a>
-<span class="sourceLineNo">260</span>      throws Exception {<a name="line.260"></a>
-<span class="sourceLineNo">261</span>    ServerName sn = TEST_UTIL.getHBaseClusterInterface().getClusterStatus().getMaster();<a name="line.261"></a>
-<span class="sourceLineNo">262</span>    TEST_UTIL.getHBaseClusterInterface().stopMaster(sn);<a name="line.262"></a>
-<span class="sourceLineNo">263</span>    TEST_UTIL.getHBaseClusterInterface().waitForMasterToStop(sn, 60000);<a name="line.263"></a>
-<span class="sourceLineNo">264</span>    List&lt;String&gt; metaZnodes = TEST_UTIL.getZooKeeperWatcher().getMetaReplicaNodes();<a name="line.264"></a>
-<span class="sourceLineNo">265</span>    assert(metaZnodes.size() == originalReplicaCount); //we should have what was configured before<a name="line.265"></a>
-<span class="sourceLineNo">266</span>    TEST_UTIL.getHBaseClusterInterface().getConf().setInt(HConstants.META_REPLICAS_NUM,<a name="line.266"></a>
-<span class="sourceLineNo">267</span>        newReplicaCount);<a name="line.267"></a>
-<span class="sourceLineNo">268</span>    TEST_UTIL.getHBaseClusterInterface().startMaster(sn.getHostname(), 0);<a name="line.268"></a>
-<span class="sourceLineNo">269</span>    TEST_UTIL.getHBaseClusterInterface().waitForActiveAndReadyMaster();<a name="line.269"></a>
-<span class="sourceLineNo">270</span>    TEST_UTIL.waitFor(10000, predicateMetaHasReplicas(newReplicaCount));<a name="line.270"></a>
-<span class="sourceLineNo">271</span>    // also check if hbck returns without errors<a name="line.271"></a>
-<span class="sourceLineNo">272</span>    TEST_UTIL.getConfiguration().setInt(HConstants.META_REPLICAS_NUM,<a name="line.272"></a>
-<span class="sourceLineNo">273</span>        newReplicaCount);<a name="line.273"></a>
-<span class="sourceLineNo">274</span>    HBaseFsck hbck = HbckTestingUtil.doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.274"></a>
-<span class="sourceLineNo">275</span>    HbckTestingUtil.assertNoErrors(hbck);<a name="line.275"></a>
-<span class="sourceLineNo">276</span>  }<a name="line.276"></a>
-<span class="sourceLineNo">277</span><a name="line.277"></a>
-<span class="sourceLineNo">278</span>  private Waiter.ExplainingPredicate&lt;Exception&gt; predicateMetaHasReplicas(<a name="line.278"></a>
-<span class="sourceLineNo">279</span>      final int newReplicaCount) {<a name="line.279"></a>
-<span class="sourceLineNo">280</span>    return new Waiter.ExplainingPredicate&lt;Exception&gt;() {<a name="line.280"></a>
-<span class="sourceLineNo">281</span>      @Override<a name="line.281"></a>
-<span class="sourceLineNo">282</span>      public String explainFailure() throws Exception {<a name="line.282"></a>
-<span class="sourceLineNo">283</span>        return checkMetaLocationAndExplain(newReplicaCount);<a name="line.283"></a>
-<span class="sourceLineNo">284</span>      }<a name="line.284"></a>
-<span class="sourceLineNo">285</span><a name="line.285"></a>
+<span class="sourceLineNo">173</span>    ServerName master = null;<a name="line.173"></a>
+<span class="sourceLineNo">174</span>    try (Connection c = ConnectionFactory.createConnection(util.getConfiguration());) {<a name="line.174"></a>
+<span class="sourceLineNo">175</span>      try (Table htable = util.createTable(TABLE, FAMILIES);) {<a name="line.175"></a>
+<span class="sourceLineNo">176</span>        util.getHBaseAdmin().flush(TableName.META_TABLE_NAME);<a name="line.176"></a>
+<span class="sourceLineNo">177</span>        Thread.sleep(conf.getInt(StorefileRefresherChore.REGIONSERVER_STOREFILE_REFRESH_PERIOD,<a name="line.177"></a>
+<span class="sourceLineNo">178</span>            30000) * 6);<a name="line.178"></a>
+<span class="sourceLineNo">179</span>        List&lt;HRegionInfo&gt; regions = MetaTableAccessor.getTableRegions(c, TABLE);<a name="line.179"></a>
+<span class="sourceLineNo">180</span>        HRegionLocation hrl = MetaTableAccessor.getRegionLocation(c, regions.get(0));<a name="line.180"></a>
+<span class="sourceLineNo">181</span>        // Ensure that the primary server for test table is not the same one as the primary<a name="line.181"></a>
+<span class="sourceLineNo">182</span>        // of the meta region since we will be killing the srv holding the meta's primary...<a name="line.182"></a>
+<span class="sourceLineNo">183</span>        // We want to be able to write to the test table even when the meta is not present ..<a name="line.183"></a>
+<span class="sourceLineNo">184</span>        // If the servers are the same, then move the test table's region out of the server<a name="line.184"></a>
+<span class="sourceLineNo">185</span>        // to another random server<a name="line.185"></a>
+<span class="sourceLineNo">186</span>        if (hrl.getServerName().equals(primary)) {<a name="line.186"></a>
+<span class="sourceLineNo">187</span>          util.getHBaseAdmin().move(hrl.getRegionInfo().getEncodedNameAsBytes(), null);<a name="line.187"></a>
+<span class="sourceLineNo">188</span>          // wait for the move to complete<a name="line.188"></a>
+<span class="sourceLineNo">189</span>          do {<a name="line.189"></a>
+<span class="sourceLineNo">190</span>            Thread.sleep(10);<a name="line.190"></a>
+<span class="sourceLineNo">191</span>            hrl = MetaTableAccessor.getRegionLocation(c, regions.get(0));<a name="line.191"></a>
+<span class="sourceLineNo">192</span>          } while (primary.equals(hrl.getServerName()));<a name="line.192"></a>
+<span class="sourceLineNo">193</span>          util.getHBaseAdmin().flush(TableName.META_TABLE_NAME);<a name="line.193"></a>
+<span class="sourceLineNo">194</span>          Thread.sleep(conf.getInt(StorefileRefresherChore.REGIONSERVER_STOREFILE_REFRESH_PERIOD,<a name="line.194"></a>
+<span class="sourceLineNo">195</span>              30000) * 3);<a name="line.195"></a>
+<span class="sourceLineNo">196</span>        }<a name="line.196"></a>
+<span class="sourceLineNo">197</span>        master = util.getHBaseClusterInterface().getClusterStatus().getMaster();<a name="line.197"></a>
+<span class="sourceLineNo">198</span>        // kill the master so that regionserver recovery is not triggered at all<a name="line.198"></a>
+<span class="sourceLineNo">199</span>        // for the meta server<a name="line.199"></a>
+<span class="sourceLineNo">200</span>        util.getHBaseClusterInterface().stopMaster(master);<a name="line.200"></a>
+<span class="sourceLineNo">201</span>        util.getHBaseClusterInterface().waitForMasterToStop(master, 60000);<a name="line.201"></a>
+<span class="sourceLineNo">202</span>        if (!master.equals(primary)) {<a name="line.202"></a>
+<span class="sourceLineNo">203</span>          util.getHBaseClusterInterface().killRegionServer(primary);<a name="line.203"></a>
+<span class="sourceLineNo">204</span>          util.getHBaseClusterInterface().waitForRegionServerToStop(primary, 60000);<a name="line.204"></a>
+<span class="sourceLineNo">205</span>        }<a name="line.205"></a>
+<span class="sourceLineNo">206</span>        ((ClusterConnection)c).clearRegionCache();<a name="line.206"></a>
+<span class="sourceLineNo">207</span>      }<a name="line.207"></a>
+<span class="sourceLineNo">208</span>      Get get = null;<a name="line.208"></a>
+<span class="sourceLineNo">209</span>      Result r = null;<a name="line.209"></a>
+<span class="sourceLineNo">210</span>      byte[] row = "test".getBytes();<a name="line.210"></a>
+<span class="sourceLineNo">211</span>      try (Table htable = c.getTable(TABLE);) {<a name="line.211"></a>
+<span class="sourceLineNo">212</span>        Put put = new Put(row);<a name="line.212"></a>
+<span class="sourceLineNo">213</span>        put.addColumn("foo".getBytes(), row, row);<a name="line.213"></a>
+<span class="sourceLineNo">214</span>        BufferedMutator m = c.getBufferedMutator(TABLE);<a name="line.214"></a>
+<span class="sourceLineNo">215</span>        m.mutate(put);<a name="line.215"></a>
+<span class="sourceLineNo">216</span>        m.flush();<a name="line.216"></a>
+<span class="sourceLineNo">217</span>        // Try to do a get of the row that was just put<a name="line.217"></a>
+<span class="sourceLineNo">218</span>        get = new Get(row);<a name="line.218"></a>
+<span class="sourceLineNo">219</span>        r = htable.get(get);<a name="line.219"></a>
+<span class="sourceLineNo">220</span>        assertTrue(Arrays.equals(r.getRow(), row));<a name="line.220"></a>
+<span class="sourceLineNo">221</span>        // now start back the killed servers and disable use of replicas. That would mean<a name="line.221"></a>
+<span class="sourceLineNo">222</span>        // calls go to the primary<a name="line.222"></a>
+<span class="sourceLineNo">223</span>        util.getHBaseClusterInterface().startMaster(master.getHostname(), 0);<a name="line.223"></a>
+<span class="sourceLineNo">224</span>        util.getHBaseClusterInterface().startRegionServer(primary.getHostname(), 0);<a name="line.224"></a>
+<span class="sourceLineNo">225</span>        util.getHBaseClusterInterface().waitForActiveAndReadyMaster();<a name="line.225"></a>
+<span class="sourceLineNo">226</span>        ((ClusterConnection)c).clearRegionCache();<a name="line.226"></a>
+<span class="sourceLineNo">227</span>      }<a name="line.227"></a>
+<span class="sourceLineNo">228</span>      conf.setBoolean(HConstants.USE_META_REPLICAS, false);<a name="line.228"></a>
+<span class="sourceLineNo">229</span>      try (Table htable = c.getTable(TABLE);) {<a name="line.229"></a>
+<span class="sourceLineNo">230</span>        r = htable.get(get);<a name="line.230"></a>
+<span class="sourceLineNo">231</span>        assertTrue(Arrays.equals(r.getRow(), row));<a name="line.231"></a>
+<span class="sourceLineNo">232</span>      }<a name="line.232"></a>
+<span class="sourceLineNo">233</span>    }<a name="line.233"></a>
+<span class="sourceLineNo">234</span>  }<a name="line.234"></a>
+<span class="sourceLineNo">235</span><a name="line.235"></a>
+<span class="sourceLineNo">236</span>  @Test<a name="line.236"></a>
+<span class="sourceLineNo">237</span>  public void testMetaLookupThreadPoolCreated() throws Exception {<a name="line.237"></a>
+<span class="sourceLineNo">238</span>    TableName TABLE = TableName.valueOf("testMetaLookupThreadPoolCreated");<a name="line.238"></a>
+<span class="sourceLineNo">239</span>    byte[][] FAMILIES = new byte[][] { Bytes.toBytes("foo") };<a name="line.239"></a>
+<span class="sourceLineNo">240</span>    if (TEST_UTIL.getHBaseAdmin().tableExists(TABLE)) {<a name="line.240"></a>
+<span class="sourceLineNo">241</span>      TEST_UTIL.getHBaseAdmin().disableTable(TABLE);<a name="line.241"></a>
+<span class="sourceLineNo">242</span>      TEST_UTIL.getHBaseAdmin().deleteTable(TABLE);<a name="line.242"></a>
+<span class="sourceLineNo">243</span>    }<a name="line.243"></a>
+<span class="sourceLineNo">244</span>    try (Table htable = TEST_UTIL.createTable(TABLE, FAMILIES);) {<a name="line.244"></a>
+<span class="sourceLineNo">245</span>      byte[] row = "test".getBytes();<a name="line.245"></a>
+<span class="sourceLineNo">246</span>      ConnectionImplementation c = ((ConnectionImplementation) TEST_UTIL.getConnection());<a name="line.246"></a>
+<span class="sourceLineNo">247</span>      // check that metalookup pool would get created<a name="line.247"></a>
+<span class="sourceLineNo">248</span>      c.relocateRegion(TABLE, row);<a name="line.248"></a>
+<span class="sourceLineNo">249</span>      ExecutorService ex = c.getCurrentMetaLookupPool();<a name="line.249"></a>
+<span class="sourceLineNo">250</span>      assert(ex != null);<a name="line.250"></a>
+<span class="sourceLineNo">251</span>    }<a name="line.251"></a>
+<span class="sourceLineNo">252</span>  }<a name="line.252"></a>
+<span class="sourceLineNo">253</span><a name="line.253"></a>
+<span class="sourceLineNo">254</span>  @Test<a name="line.254"></a>
+<span class="sourceLineNo">255</span>  public void testChangingReplicaCount() throws Exception {<a name="line.255"></a>
+<span class="sourceLineNo">256</span>    // tests changing the replica count across master restarts<a name="line.256"></a>
+<span class="sourceLineNo">257</span>    // reduce the replica count from 3 to 2<a name="line.257"></a>
+<span class="sourceLineNo">258</span>    stopMasterAndValidateReplicaCount(3, 2);<a name="line.258"></a>
+<span class="sourceLineNo">259</span>    // increase the replica count from 2 to 3<a name="line.259"></a>
+<span class="sourceLineNo">260</span>    stopMasterAndValidateReplicaCount(2, 3);<a name="line.260"></a>
+<span class="sourceLineNo">261</span>  }<a name="line.261"></a>
+<span class="sourceLineNo">262</span><a name="line.262"></a>
+<span class="sourceLineNo">263</span>  private void stopMasterAndValidateReplicaCount(final int originalReplicaCount,<a name="line.263"></a>
+<span class="sourceLineNo">264</span>      final int newReplicaCount)<a name="line.264"></a>
+<span class="sourceLineNo">265</span>      throws Exception {<a name="line.265"></a>
+<span class="sourceLineNo">266</span>    ServerName sn = TEST_UTIL.getHBaseClusterInterface().getClusterStatus().getMaster();<a name="line.266"></a>
+<span class="sourceLineNo">267</span>    TEST_UTIL.getHBaseClusterInterface().stopMaster(sn);<a name="line.267"></a>
+<span class="sourceLineNo">268</span>    TEST_UTIL.getHBaseClusterInterface().waitForMasterToStop(sn, 60000);<a name="line.268"></a>
+<span class="sourceLineNo">269</span>    List&lt;String&gt; metaZnodes = TEST_UTIL.getZooKeeperWatcher().getMetaReplicaNodes();<a name="line.269"></a>
+<span class="sourceLineNo">270</span>    assert(metaZnodes.size() == originalReplicaCount); //we should have what was configured before<a name="line.270"></a>
+<span class="sourceLineNo">271</span>    TEST_UTIL.getHBaseClusterInterface().getConf().setInt(HConstants.META_REPLICAS_NUM,<a name="line.271"></a>
+<span class="sourceLineNo">272</span>        newReplicaCount);<a name="line.272"></a>
+<span class="sourceLineNo">273</span>    TEST_UTIL.getHBaseClusterInterface().startMaster(sn.getHostname(), 0);<a name="line.273"></a>
+<span class="sourceLineNo">274</span>    TEST_UTIL.getHBaseClusterInterface().waitForActiveAndReadyMaster();<a name="line.274"></a>
+<span class="sourceLineNo">275</span>    TEST_UTIL.waitFor(10000, predicateMetaHasReplicas(newReplicaCount));<a name="line.275"></a>
+<span class="sourceLineNo">276</span>    // also check if hbck returns without errors<a name="line.276"></a>
+<span class="sourceLineNo">277</span>    TEST_UTIL.getConfiguration().setInt(HConstants.META_REPLICAS_NUM,<a name="line.277"></a>
+<span class="sourceLineNo">278</span>        newReplicaCount);<a name="line.278"></a>
+<span class="sourceLineNo">279</span>    HBaseFsck hbck = HbckTestingUtil.doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.279"></a>
+<span class="sourceLineNo">280</span>    HbckTestingUtil.assertNoErrors(hbck);<a name="line.280"></a>
+<span class="sourceLineNo">281</span>  }<a name="line.281"></a>
+<span class="sourceLineNo">282</span><a name="line.282"></a>
+<span class="sourceLineNo">283</span>  private Waiter.ExplainingPredicate&lt;Exception&gt; predicateMetaHasReplicas(<a name="line.283"></a>
+<span class="sourceLineNo">284</span>      final int newReplicaCount) {<a name="line.284"></a>
+<span class="sourceLineNo">285</span>    return new Waiter.ExplainingPredicate&lt;Exception&gt;() {<a name="line.285"></a>
 <span class="sourceLineNo">286</span>      @Override<a name="line.286"></a>
-<span class="sourceLineNo">287</span>      public boolean evaluate() throws Exception {<a name="line.287"></a>
-<span class="sourceLineNo">288</span>        return checkMetaLocationAndExplain(newReplicaCount) == null;<a name="line.288"></a>
+<span class="sourceLineNo">287</span>      public String explainFailure() throws Exception {<a name="line.287"></a>
+<span class="sourceLineNo">288</span>        return checkMetaLocationAndExplain(newReplicaCount);<a name="line.288"></a>
 <span class="sourceLineNo">289</span>      }<a name="line.289"></a>
-<span class="sourceLineNo">290</span>    };<a name="line.290"></a>
-<span class="sourceLineNo">291</span>  }<a name="line.291"></a>
-<span class="sourceLineNo">292</span><a name="line.292"></a>
-<span class="sourceLineNo">293</span>  @Nullable<a name="line.293"></a>
-<span class="sourceLineNo">294</span>  private String checkMetaLocationAndExplain(int originalReplicaCount)<a name="line.294"></a>
-<span class="sourceLineNo">295</span>      throws KeeperException, IOException {<a name="line.295"></a>
-<span class="sourceLineNo">296</span>    List&lt;String&gt; metaZnodes = TEST_UTIL.getZooKeeperWatcher().getMetaReplicaNodes();<a name="line.296"></a>
-<span class="sourceLineNo">297</span>    if (metaZnodes.size() == originalReplicaCount) {<a name="line.297"></a>
-<span class="sourceLineNo">298</span>      RegionLocations rl = ((ClusterConnection) TEST_UTIL.getConnection())<a name="line.298"></a>
-<span class="sourceLineNo">299</span>          .locateRegion(TableName.META_TABLE_NAME,<a name="line.299"></a>
-<span class="sourceLineNo">300</span>              HConstants.EMPTY_START_ROW, false, false);<a name="line.300"></a>
-<span class="sourceLineNo">301</span>      for (HRegionLocation location : rl.getRegionLocations()) {<a name="line.301"></a>
-<span class="sourceLineNo">302</span>        if (location == null) {<a name="line.302"></a>
-<span class="sourceLineNo">303</span>          return "Null location found in " + rl.toString();<a name="line.303"></a>
-<span class="sourceLineNo">304</span>        }<a name="line.304"></a>
-<span class="sourceLineNo">305</span>        if (location.getRegionInfo() == null) {<a name="line.305"></a>
-<span class="sourceLineNo">306</span>          return "Null regionInfo for location " + location;<a name="line.306"></a>
-<span class="sourceLineNo">307</span>        }<a name="line.307"></a>
-<span class="sourceLineNo">308</span>        if (location.getHostname() == null) {<a name="line.308"></a>
-<span class="sourceLineNo">309</span>          return "Null hostName for location " + location;<a name="line.309"></a>
-<span class="sourceLineNo">310</span>        }<a name="line.310"></a>
-<span class="sourceLineNo">311</span>      }<a name="line.311"></a>
-<span class="sourceLineNo">312</span>      return null; // OK<a name="line.312"></a>
-<span class="sourceLineNo">313</span>    }<a name="line.313"></a>
-<span class="sourceLineNo">314</span>    return "Replica count is not as expected " + originalReplicaCount + " &lt;&gt; " + metaZnodes.size()<a name="line.314"></a>
-<span class="sourceLineNo">315</span>        + "(" + metaZnodes.toString() + ")";<a name="line.315"></a>
-<span class="sourceLineNo">316</span>  }<a name="line.316"></a>
-<span class="sourceLineNo">317</span><a name="line.317"></a>
-<span class="sourceLineNo">318</span>  @Test<a name="line.318"></a>
-<span class="sourceLineNo">319</span>  public void testHBaseFsckWithMetaReplicas() throws Exception {<a name="line.319"></a>
-<span class="sourceLineNo">320</span>    HBaseFsck hbck = HbckTestingUtil.doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.320"></a>
-<span class="sourceLineNo">321</span>    HbckTestingUtil.assertNoErrors(hbck);<a name="line.321"></a>
-<span class="sourceLineNo">322</span>  }<a name="line.322"></a>
-<span class="sourceLineNo">323</span><a name="line.323"></a>
-<span class="sourceLineNo">324</span>  @Test<a name="line.324"></a>
-<span class="sourceLineNo">325</span>  public void testHBaseFsckWithFewerMetaReplicas() throws Exception {<a name="line.325"></a>
-<span class="sourceLineNo">326</span>    ClusterConnection c = (ClusterConnection)ConnectionFactory.createConnection(<a name="line.326"></a>
-<span class="sourceLineNo">327</span>        TEST_UTIL.getConfiguration());<a name="line.327"></a>
-<span class="sourceLineNo">328</span>    RegionLocations rl = c.locateRegion(TableName.META_TABLE_NAME, HConstants.EMPTY_START_ROW,<a name="line.328"></a>
-<span class="sourceLineNo">329</span>        false, false);<a name="line.329"></a>
-<span class="sourceLineNo">330</span>    HBaseFsckRepair.closeRegionSilentlyAndWait(c,<a name="line.330"></a>
-<span class="sourceLineNo">331</span>        rl.getRegionLocation(1).getServerName(), rl.getRegionLocation(1).getRegionInfo());<a name="line.331"></a>
-<span class="sourceLineNo">332</span>    // check that problem exists<a name="line.332"></a>
-<span class="sourceLineNo">333</span>    HBaseFsck hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.333"></a>
-<span class="sourceLineNo">334</span>    assertErrors(hbck, new ERROR_CODE[]{ERROR_CODE.UNKNOWN,ERROR_CODE.NO_META_REGION});<a name="line.334"></a>
-<span class="sourceLineNo">335</span>    // fix the problem<a name="line.335"></a>
-<span class="sourceLineNo">336</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), true);<a name="line.336"></a>
-<span class="sourceLineNo">337</span>    // run hbck again to make sure we don't see any errors<a name="line.337"></a>
-<span class="sourceLineNo">338</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.338"></a>
-<span class="sourceLineNo">339</span>    assertErrors(hbck, new ERROR_CODE[]{});<a name="line.339"></a>
-<span class="sourceLineNo">340</span>  }<a name="line.340"></a>
-<span class="sourceLineNo">341</span><a name="line.341"></a>
-<span class="sourceLineNo">342</span>  @Test<a name="line.342"></a>
-<span class="sourceLineNo">343</span>  public void testHBaseFsckWithFewerMetaReplicaZnodes() throws Exception {<a name="line.343"></a>
-<span class="sourceLineNo">344</span>    ClusterConnection c = (ClusterConnection)ConnectionFactory.createConnection(<a name="line.344"></a>
-<span class="sourceLineNo">345</span>        TEST_UTIL.getConfiguration());<a name="line.345"></a>
-<span class="sourceLineNo">346</span>    RegionLocations rl = c.locateRegion(TableName.META_TABLE_NAME, HConstants.EMPTY_START_ROW,<a name="line.346"></a>
-<span class="sourceLineNo">347</span>        false, false);<a name="line.347"></a>
-<span class="sourceLineNo">348</span>    HBaseFsckRepair.closeRegionSilentlyAndWait(c,<a name="line.348"></a>
-<span class="sourceLineNo">349</span>        rl.getRegionLocation(2).getServerName(), rl.getRegionLocation(2).getRegionInfo());<a name="line.349"></a>
-<span class="sourceLineNo">350</span>    ZooKeeperWatcher zkw = TEST_UTIL.getZooKeeperWatcher();<a name="line.350"></a>
-<span class="sourceLineNo">351</span>    ZKUtil.deleteNode(zkw, zkw.getZNodeForReplica(2));<a name="line.351"></a>
-<span class="sourceLineNo">352</span>    // check that problem exists<a name="line.352"></a>
-<span class="sourceLineNo">353</span>    HBaseFsck hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.353"></a>
-<span class="sourceLineNo">354</span>    assertErrors(hbck, new ERROR_CODE[]{ERROR_CODE.UNKNOWN,ERROR_CODE.NO_META_REGION});<a name="line.354"></a>
-<span class="sourceLineNo">355</span>    // fix the problem<a name="line.355"></a>
-<span class="sourceLineNo">356</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), true);<a name="line.356"></a>
-<span class="sourceLineNo">357</span>    // run hbck again to make sure we don't see any errors<a name="line.357"></a>
-<span class="sourceLineNo">358</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.358"></a>
-<span class="sourceLineNo">359</span>    assertErrors(hbck, new ERROR_CODE[]{});<a name="line.359"></a>
-<span class="sourceLineNo">360</span>  }<a name="line.360"></a>
-<span class="sourceLineNo">361</span><a name="line.361"></a>
-<span class="sourceLineNo">362</span>  @Test<a name="line.362"></a>
-<span class="sourceLineNo">363</span>  public void testAccessingUnknownTables() throws Exception {<a name="line.363"></a>
-<span class="sourceLineNo">364</span>    Configuration conf = new Configuration(TEST_UTIL.getConfiguration());<a name="line.364"></a>
-<span class="sourceLineNo">365</span>    conf.setBoolean(HConstants.USE_META_REPLICAS, true);<a name="line.365"></a>
-<span class="sourceLineNo">366</span>    Table table = TEST_UTIL.getConnection().getTable(TableName.valueOf("RandomTable"));<a name="line.366"></a>
-<span class="sourceLineNo">367</span>    Get get = new Get(Bytes.toBytes("foo"));<a name="line.367"></a>
-<span class="sourceLineNo">368</span>    try {<a name="line.368"></a>
-<span class="sourceLineNo">369</span>      table.get(get);<a name="line.369"></a>
-<span class="sourceLineNo">370</span>    } catch (TableNotFoundException t) {<a name="line.370"></a>
-<span class="sourceLineNo">371</span>      return;<a name="line.371"></a>
-<span class="sourceLineNo">372</span>    }<a name="line.372"></a>
-<span class="sourceLineNo">373</span>    fail("Expected TableNotFoundException");<a name="line.373"></a>
-<span class="sourceLineNo">374</span>  }<a name="line.374"></a>
-<span class="sourceLineNo">375</span><a name="line.375"></a>
-<span class="sourceLineNo">376</span>  @Test<a name="line.376"></a>
-<span class="sourceLineNo">377</span>  public void testMetaAddressChange() throws Exception {<a name="line.377"></a>
-<span class="sourceLineNo">378</span>    // checks that even when the meta's location changes, the various<a name="line.378"></a>
-<span class="sourceLineNo">379</span>    // caches update themselves. Uses the master operations to test<a name="line.379"></a>
-<span class="sourceLineNo">380</span>    // this<a name="line.380"></a>
-<span class="sourceLineNo">381</span>    Configuration conf = TEST_UTIL.getConfiguration();<a name="line.381"></a>
-<span class="sourceLineNo">382</span>    ZooKeeperWatcher zkw = TEST_UTIL.getZooKeeperWatcher();<a name="line.382"></a>
-<span class="sourceLineNo">383</span>    String baseZNode = conf.get(HConstants.ZOOKEEPER_ZNODE_PARENT,<a name="line.383"></a>
-<span class="sourceLineNo">384</span>        HConstants.DEFAULT_ZOOKEEPER_ZNODE_PARENT);<a name="line.384"></a>
-<span class="sourceLineNo">385</span>    String primaryMetaZnode = ZKUtil.joinZNode(baseZNode,<a name="line.385"></a>
-<span class="sourceLineNo">386</span>        conf.get("zookeeper.znode.metaserver", "meta-region-server"));<a name="line.386"></a>
-<span class="sourceLineNo">387</span>    // check that the data in the znode is parseable (this would also mean the znode exists)<a name="line.387"></a>
-<span class="sourceLineNo">388</span>    byte[] data = ZKUtil.getData(zkw, primaryMetaZnode);<a name="line.388"></a>
-<span class="sourceLineNo">389</span>    ServerName currentServer = ServerName.parseFrom(data);<a name="line.389"></a>
-<span class="sourceLineNo">390</span>    Collection&lt;ServerName&gt; liveServers = TEST_UTIL.getHBaseAdmin().getClusterStatus().getServers();<a name="line.390"></a>
-<span class="sourceLineNo">391</span>    ServerName moveToServer = null;<a name="line.391"></a>
-<span class="sourceLineNo">392</span>    for (ServerName s : liveServers) {<a name="line.392"></a>
-<span class="sourceLineNo">393</span>      if (!currentServer.equals(s)) {<a name="line.393"></a>
-<span class="sourceLineNo">394</span>        moveToServer = s;<a name="line.394"></a>
-<span class="sourceLineNo">395</span>      }<a name="line.395"></a>
-<span class="sourceLineNo">396</span>    }<a name="line.396"></a>
-<span class="sourceLineNo">397</span>    assert(moveToServer != null);<a name="line.397"></a>
-<span class="sourceLineNo">398</span>    String tableName = "randomTable5678";<a name="line.398"></a>
-<span class="sourceLineNo">399</span>    TEST_UTIL.createTable(TableName.valueOf(tableName), "f");<a name="line.399"></a>
-<span class="sourceLineNo">400</span>    assertTrue(TEST_UTIL.getHBaseAdmin().tableExists(tableName));<a name="line.400"></a>
-<span class="sourceLineNo">401</span>    TEST_UTIL.getHBaseAdmin().move(HRegionInfo.FIRST_META_REGIONINFO.getEncodedNameAsBytes(),<a name="line.401"></a>
-<span class="sourceLineNo">402</span>        Bytes.toBytes(moveToServer.getServerName()));<a name="line.402"></a>
-<span class="sourceLineNo">403</span>    int i = 0;<a name="line.403"></a>
-<span class="sourceLineNo">404</span>    do {<a name="line.404"></a>
-<span class="sourceLineNo">405</span>      Thread.sleep(10);<a name="line.405"></a>
-<span class="sourceLineNo">406</span>      data = ZKUtil.getData(zkw, primaryMetaZnode);<a name="line.406"></a>
-<span class="sourceLineNo">407</span>      currentServer = ServerName.parseFrom(data);<a name="line.407"></a>
-<span class="sourceLineNo">408</span>      i++;<a name="line.408"></a>
-<span class="sourceLineNo">409</span>    } while (!moveToServer.equals(currentServer) &amp;&amp; i &lt; 1000); //wait for 10 seconds overall<a name="line.409"></a>
-<span class="sourceLineNo">410</span>    assert(i != 1000);<a name="line.410"></a>
-<span class="sourceLineNo">411</span>    TEST_UTIL.getHBaseAdmin().disableTable("randomTable5678");<a name="line.411"></a>
-<span class="sourceLineNo">412</span>    assertTrue(TEST_UTIL.getHBaseAdmin().isTableDisabled("randomTable5678"));<a name="line.412"></a>
-<span class="sourceLineNo">413</span>  }<a name="line.413"></a>
-<span class="sourceLineNo">414</span><a name="line.414"></a>
-<span class="sourceLineNo">415</span>  @Test<a name="line.415"></a>
-<span class="sourceLineNo">416</span>  public void testShutdownOfReplicaHolder() throws Exception {<a name="line.416"></a>
-<span class="sourceLineNo">417</span>    // checks that the when the server holding meta replica is shut down, the meta replica<a name="line.417"></a>
-<span class="sourceLineNo">418</span>    // can be recovered<a name="line.418"></a>
-<span class="sourceLineNo">419</span>    ClusterConnection conn = (ClusterConnection)<a name="line.419"></a>
-<span class="sourceLineNo">420</span>      ConnectionFactory.createConnection(TEST_UTIL.getConfiguration());<a name="line.420"></a>
-<span class="sourceLineNo">421</span>    RegionLocations rl = conn.<a name="line.421"></a>
-<span class="sourceLineNo">422</span>        locateRegion(TableName.META_TABLE_NAME, Bytes.toBytes(""), false, true);<a name="line.422"></a>
-<span class="sourceLineNo">423</span>    HRegionLocation hrl = rl.getRegionLocation(1);<a name="line.423"></a>
-<span class="sourceLineNo">424</span>    ServerName oldServer = hrl.getServerName();<a name="line.424"></a>
-<span class="sourceLineNo">425</span>    TEST_UTIL.getHBaseClusterInterface().killRegionServer(oldServer);<a name="line.425"></a>
-<span class="sourceLineNo">426</span>    int i = 0;<a name="line.426"></a>
-<span class="sourceLineNo">427</span>    do {<a name="line.427"></a>
-<span class="sourceLineNo">428</span>      LOG.debug("Waiting for the replica " + hrl.getRegionInfo() + " to come up");<a name="line.428"></a>
-<span class="sourceLineNo">429</span>      Thread.sleep(30000); //wait for the detection/recovery<a name="line.429"></a>
-<span class="sourceLineNo">430</span>      rl = conn.locateRegion(TableName.META_TABLE_NAME, Bytes.toBytes(""), false, true);<a name="line.430"></a>
-<span class="sourceLineNo">431</span>      hrl = rl.getRegionLocation(1);<a name="line.431"></a>
-<span class="sourceLineNo">432</span>      i++;<a name="line.432"></a>
-<span class="sourceLineNo">433</span>    } while ((hrl == null || hrl.getServerName().equals(oldServer)) &amp;&amp; i &lt; 3);<a name="line.433"></a>
-<span class="sourceLineNo">434</span>    assertTrue(i != 3);<a name="line.434"></a>
-<span class="sourceLineNo">435</span>    conn.close();<a name="line.435"></a>
-<span class="sourceLineNo">436</span>  }<a name="line.436"></a>
-<span class="sourceLineNo">437</span><a name="line.437"></a>
-<span class="sourceLineNo">438</span>  @Test<a name="line.438"></a>
-<span class="sourceLineNo">439</span>  public void testHBaseFsckWithExcessMetaReplicas() throws Exception {<a name="line.439"></a>
-<span class="sourceLineNo">440</span>    HBaseFsck hbck = new HBaseFsck(TEST_UTIL.getConfiguration());<a name="line.440"></a>
-<span class="sourceLineNo">441</span>    // Create a meta replica (this will be the 4th one) and assign it<a name="line.441"></a>
-<span class="sourceLineNo">442</span>    HRegionInfo h = RegionReplicaUtil.getRegionInfoForReplica(<a name="line.442"></a>
-<span class="sourceLineNo">443</span>        HRegionInfo.FIRST_META_REGIONINFO, 3);<a name="line.443"></a>
-<span class="sourceLineNo">444</span>    // create in-memory state otherwise master won't assign<a name="line.444"></a>
-<span class="sourceLineNo">445</span>    TEST_UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager()<a name="line.445"></a>
-<span class="sourceLineNo">446</span>             .getRegionStates().createRegionState(h);<a name="line.446"></a>
-<span class="sourceLineNo">447</span>    TEST_UTIL.getMiniHBaseCluster().getMaster().assignRegion(h);<a name="line.447"></a>
-<span class="sourceLineNo">448</span>    HBaseFsckRepair.waitUntilAssigned(TEST_UTIL.getHBaseAdmin(), h);<a name="line.448"></a>
-<span class="sourceLineNo">449</span>    // check that problem exists<a name="line.449"></a>
-<span class="sourceLineNo">450</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.450"></a>
-<span class="sourceLineNo">451</span>    assertErrors(hbck, new ERROR_CODE[]{ERROR_CODE.UNKNOWN, ERROR_CODE.SHOULD_NOT_BE_DEPLOYED});<a name="line.451"></a>
-<span class="sourceLineNo">452</span>    // fix the problem<a name="line.452"></a>
-<span class="sourceLineNo">453</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), true);<a name="line.453"></a>
-<span class="sourceLineNo">454</span>    // run hbck again to make sure we don't see any errors<a name="line.454"></a>
-<span class="sourceLineNo">455</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.455"></a>
-<span class="sourceLineNo">456</span>    assertErrors(hbck, new ERROR_CODE[]{});<a name="line.456"></a>
-<span class="sourceLineNo">457</span>  }<a name="line.457"></a>
-<span class="sourceLineNo">458</span>}<a name="line.458"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span>      @Override<a name="line.291"></a>
+<span class="sourceLineNo">292</span>      public boolean evaluate() throws Exception {<a name="line.292"></a>
+<span class="sourceLineNo">293</span>        return checkMetaLocationAndExplain(newReplicaCount) == null;<a name="line.293"></a>
+<span class="sourceLineNo">294</span>      }<a name="line.294"></a>
+<span class="sourceLineNo">295</span>    };<a name="line.295"></a>
+<span class="sourceLineNo">296</span>  }<a name="line.296"></a>
+<span class="sourceLineNo">297</span><a name="line.297"></a>
+<span class="sourceLineNo">298</span>  @Nullable<a name="line.298"></a>
+<span class="sourceLineNo">299</span>  private String checkMetaLocationAndExplain(int originalReplicaCount)<a name="line.299"></a>
+<span class="sourceLineNo">300</span>      throws KeeperException, IOException {<a name="line.300"></a>
+<span class="sourceLineNo">301</span>    List&lt;String&gt; metaZnodes = TEST_UTIL.getZooKeeperWatcher().getMetaReplicaNodes();<a name="line.301"></a>
+<span class="sourceLineNo">302</span>    if (metaZnodes.size() == originalReplicaCount) {<a name="line.302"></a>
+<span class="sourceLineNo">303</span>      RegionLocations rl = ((ClusterConnection) TEST_UTIL.getConnection())<a name="line.303"></a>
+<span class="sourceLineNo">304</span>          .locateRegion(TableName.META_TABLE_NAME,<a name="line.304"></a>
+<span class="sourceLineNo">305</span>              HConstants.EMPTY_START_ROW, false, false);<a name="line.305"></a>
+<span class="sourceLineNo">306</span>      for (HRegionLocation location : rl.getRegionLocations()) {<a name="line.306"></a>
+<span class="sourceLineNo">307</span>        if (location == null) {<a name="line.307"></a>
+<span class="sourceLineNo">308</span>          return "Null location found in " + rl.toString();<a name="line.308"></a>
+<span class="sourceLineNo">309</span>        }<a name="line.309"></a>
+<span class="sourceLineNo">310</span>        if (location.getRegionInfo() == null) {<a name="line.310"></a>
+<span class="sourceLineNo">311</span>          return "Null regionInfo for location " + location;<a name="line.311"></a>
+<span class="sourceLineNo">312</span>        }<a name="line.312"></a>
+<span class="sourceLineNo">313</span>        if (location.getHostname() == null) {<a name="line.313"></a>
+<span class="sourceLineNo">314</span>          return "Null hostName for location " + location;<a name="line.314"></a>
+<span class="sourceLineNo">315</span>        }<a name="line.315"></a>
+<span class="sourceLineNo">316</span>      }<a name="line.316"></a>
+<span class="sourceLineNo">317</span>      return null; // OK<a name="line.317"></a>
+<span class="sourceLineNo">318</span>    }<a name="line.318"></a>
+<span class="sourceLineNo">319</span>    return "Replica count is not as expected " + originalReplicaCount + " &lt;&gt; " + metaZnodes.size()<a name="line.319"></a>
+<span class="sourceLineNo">320</span>        + "(" + metaZnodes.toString() + ")";<a name="line.320"></a>
+<span class="sourceLineNo">321</span>  }<a name="line.321"></a>
+<span class="sourceLineNo">322</span><a name="line.322"></a>
+<span class="sourceLineNo">323</span>  @Test<a name="line.323"></a>
+<span class="sourceLineNo">324</span>  public void testHBaseFsckWithMetaReplicas() throws Exception {<a name="line.324"></a>
+<span class="sourceLineNo">325</span>    HBaseFsck hbck = HbckTestingUtil.doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.325"></a>
+<span class="sourceLineNo">326</span>    HbckTestingUtil.assertNoErrors(hbck);<a name="line.326"></a>
+<span class="sourceLineNo">327</span>  }<a name="line.327"></a>
+<span class="sourceLineNo">328</span><a name="line.328"></a>
+<span class="sourceLineNo">329</span>  @Test<a name="line.329"></a>
+<span class="sourceLineNo">330</span>  public void testHBaseFsckWithFewerMetaReplicas() throws Exception {<a name="line.330"></a>
+<span class="sourceLineNo">331</span>    ClusterConnection c = (ClusterConnection)ConnectionFactory.createConnection(<a name="line.331"></a>
+<span class="sourceLineNo">332</span>        TEST_UTIL.getConfiguration());<a name="line.332"></a>
+<span class="sourceLineNo">333</span>    RegionLocations rl = c.locateRegion(TableName.META_TABLE_NAME, HConstants.EMPTY_START_ROW,<a name="line.333"></a>
+<span class="sourceLineNo">334</span>        false, false);<a name="line.334"></a>
+<span class="sourceLineNo">335</span>    HBaseFsckRepair.closeRegionSilentlyAndWait(c,<a name="line.335"></a>
+<span class="sourceLineNo">336</span>        rl.getRegionLocation(1).getServerName(), rl.getRegionLocation(1).getRegionInfo());<a name="line.336"></a>
+<span class="sourceLineNo">337</span>    // check that problem exists<a name="line.337"></a>
+<span class="sourceLineNo">338</span>    HBaseFsck hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.338"></a>
+<span class="sourceLineNo">339</span>    assertErrors(hbck, new ERROR_CODE[]{ERROR_CODE.UNKNOWN,ERROR_CODE.NO_META_REGION});<a name="line.339"></a>
+<span class="sourceLineNo">340</span>    // fix the problem<a name="line.340"></a>
+<span class="sourceLineNo">341</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), true);<a name="line.341"></a>
+<span class="sourceLineNo">342</span>    // run hbck again to make sure we don't see any errors<a name="line.342"></a>
+<span class="sourceLineNo">343</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.343"></a>
+<span class="sourceLineNo">344</span>    assertErrors(hbck, new ERROR_CODE[]{});<a name="line.344"></a>
+<span class="sourceLineNo">345</span>  }<a name="line.345"></a>
+<span class="sourceLineNo">346</span><a name="line.346"></a>
+<span class="sourceLineNo">347</span>  @Test<a name="line.347"></a>
+<span class="sourceLineNo">348</span>  public void testHBaseFsckWithFewerMetaReplicaZnodes() throws Exception {<a name="line.348"></a>
+<span class="sourceLineNo">349</span>    ClusterConnection c = (ClusterConnection)ConnectionFactory.createConnection(<a name="line.349"></a>
+<span class="sourceLineNo">350</span>        TEST_UTIL.getConfiguration());<a name="line.350"></a>
+<span class="sourceLineNo">351</span>    RegionLocations rl = c.locateRegion(TableName.META_TABLE_NAME, HConstants.EMPTY_START_ROW,<a name="line.351"></a>
+<span class="sourceLineNo">352</span>        false, false);<a name="line.352"></a>
+<span class="sourceLineNo">353</span>    HBaseFsckRepair.closeRegionSilentlyAndWait(c,<a name="line.353"></a>
+<span class="sourceLineNo">354</span>        rl.getRegionLocation(2).getServerName(), rl.getRegionLocation(2).getRegionInfo());<a name="line.354"></a>
+<span class="sourceLineNo">355</span>    ZooKeeperWatcher zkw = TEST_UTIL.getZooKeeperWatcher();<a name="line.355"></a>
+<span class="sourceLineNo">356</span>    ZKUtil.deleteNode(zkw, zkw.getZNodeForReplica(2));<a name="line.356"></a>
+<span class="sourceLineNo">357</span>    // check that problem exists<a name="line.357"></a>
+<span class="sourceLineNo">358</span>    HBaseFsck hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.358"></a>
+<span class="sourceLineNo">359</span>    assertErrors(hbck, new ERROR_CODE[]{ERROR_CODE.UNKNOWN,ERROR_CODE.NO_META_REGION});<a name="line.359"></a>
+<span class="sourceLineNo">360</span>    // fix the problem<a name="line.360"></a>
+<span class="sourceLineNo">361</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), true);<a name="line.361"></a>
+<span class="sourceLineNo">362</span>    // run hbck again to make sure we don't see any errors<a name="line.362"></a>
+<span class="sourceLineNo">363</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.363"></a>
+<span class="sourceLineNo">364</span>    assertErrors(hbck, new ERROR_CODE[]{});<a name="line.364"></a>
+<span class="sourceLineNo">365</span>  }<a name="line.365"></a>
+<span class="sourceLineNo">366</span><a name="line.366"></a>
+<span class="sourceLineNo">367</span>  @Test<a name="line.367"></a>
+<span class="sourceLineNo">368</span>  public void testAccessingUnknownTables() throws Exception {<a name="line.368"></a>
+<span class="sourceLineNo">369</span>    Configuration conf = new Configuration(TEST_UTIL.getConfiguration());<a name="line.369"></a>
+<span class="sourceLineNo">370</span>    conf.setBoolean(HConstants.USE_META_REPLICAS, true);<a name="line.370"></a>
+<span class="sourceLineNo">371</span>    Table table = TEST_UTIL.getConnection().getTable(TableName.valueOf("RandomTable"));<a name="line.371"></a>
+<span class="sourceLineNo">372</span>    Get get = new Get(Bytes.toBytes("foo"));<a name="line.372"></a>
+<span class="sourceLineNo">373</span>    try {<a name="line.373"></a>
+<span class="sourceLineNo">374</span>      table.get(get);<a name="line.374"></a>
+<span class="sourceLineNo">375</span>    } catch (TableNotFoundException t) {<a name="line.375"></a>
+<span class="sourceLineNo">376</span>      return;<a name="line.376"></a>
+<span class="sourceLineNo">377</span>    }<a name="line.377"></a>
+<span class="sourceLineNo">378</span>    fail("Expected TableNotFoundException");<a name="line.378"></a>
+<span class="sourceLineNo">379</span>  }<a name="line.379"></a>
+<span class="sourceLineNo">380</span><a name="line.380"></a>
+<span class="sourceLineNo">381</span>  @Test<a name="line.381"></a>
+<span class="sourceLineNo">382</span>  public void testMetaAddressChange() throws Exception {<a name="line.382"></a>
+<span class="sourceLineNo">383</span>    // checks that even when the meta's location changes, the various<a name="line.383"></a>
+<span class="sourceLineNo">384</span>    // caches update themselves. Uses the master operations to test<a name="line.384"></a>
+<span class="sourceLineNo">385</span>    // this<a name="line.385"></a>
+<span class="sourceLineNo">386</span>    Configuration conf = TEST_UTIL.getConfiguration();<a name="line.386"></a>
+<span class="sourceLineNo">387</span>    ZooKeeperWatcher zkw = TEST_UTIL.getZooKeeperWatcher();<a name="line.387"></a>
+<span class="sourceLineNo">388</span>    String baseZNode = conf.get(HConstants.ZOOKEEPER_ZNODE_PARENT,<a name="line.388"></a>
+<span class="sourceLineNo">389</span>        HConstants.DEFAULT_ZOOKEEPER_ZNODE_PARENT);<a name="line.389"></a>
+<span class="sourceLineNo">390</span>    String primaryMetaZnode = ZKUtil.joinZNode(baseZNode,<a name="line.390"></a>
+<span class="sourceLineNo">391</span>        conf.get("zookeeper.znode.metaserver", "meta-region-server"));<a name="line.391"></a>
+<span class="sourceLineNo">392</span>    // check that the data in the znode is parseable (this would also mean the znode exists)<a name="line.392"></a>
+<span class="sourceLineNo">393</span>    byte[] data = ZKUtil.getData(zkw, primaryMetaZnode);<a name="line.393"></a>
+<span class="sourceLineNo">394</span>    ServerName currentServer = ServerName.parseFrom(data);<a name="line.394"></a>
+<span class="sourceLineNo">395</span>    Collection&lt;ServerName&gt; liveServers = TEST_UTIL.getHBaseAdmin().getClusterStatus().getServers();<a name="line.395"></a>
+<span class="sourceLineNo">396</span>    ServerName moveToServer = null;<a name="line.396"></a>
+<span class="sourceLineNo">397</span>    for (ServerName s : liveServers) {<a name="line.397"></a>
+<span class="sourceLineNo">398</span>      if (!currentServer.equals(s)) {<a name="line.398"></a>
+<span class="sourceLineNo">399</span>        moveToServer = s;<a name="line.399"></a>
+<span class="sourceLineNo">400</span>      }<a name="line.400"></a>
+<span class="sourceLineNo">401</span>    }<a name="line.401"></a>
+<span class="sourceLineNo">402</span>    assert(moveToServer != null);<a name="line.402"></a>
+<span class="sourceLineNo">403</span>    String tableName = "randomTable5678";<a name="line.403"></a>
+<span class="sourceLineNo">404</span>    TEST_UTIL.createTable(TableName.valueOf(tableName), "f");<a name="line.404"></a>
+<span class="sourceLineNo">405</span>    assertTrue(TEST_UTIL.getHBaseAdmin().tableExists(tableName));<a name="line.405"></a>
+<span class="sourceLineNo">406</span>    TEST_UTIL.getHBaseAdmin().move(HRegionInfo.FIRST_META_REGIONINFO.getEncodedNameAsBytes(),<a name="line.406"></a>
+<span class="sourceLineNo">407</span>        Bytes.toBytes(moveToServer.getServerName()));<a name="line.407"></a>
+<span class="sourceLineNo">408</span>    int i = 0;<a name="line.408"></a>
+<span class="sourceLineNo">409</span>    do {<a name="line.409"></a>
+<span class="sourceLineNo">410</span>      Thread.sleep(10);<a name="line.410"></a>
+<span class="sourceLineNo">411</span>      data = ZKUtil.getData(zkw, primaryMetaZnode);<a name="line.411"></a>
+<span class="sourceLineNo">412</span>      currentServer = ServerName.parseFrom(data);<a name="line.412"></a>
+<span class="sourceLineNo">413</span>      i++;<a name="line.413"></a>
+<span class="sourceLineNo">414</span>    } while (!moveToServer.equals(currentServer) &amp;&amp; i &lt; 1000); //wait for 10 seconds overall<a name="line.414"></a>
+<span class="sourceLineNo">415</span>    assert(i != 1000);<a name="line.415"></a>
+<span class="sourceLineNo">416</span>    TEST_UTIL.getHBaseAdmin().disableTable("randomTable5678");<a name="line.416"></a>
+<span class="sourceLineNo">417</span>    assertTrue(TEST_UTIL.getHBaseAdmin().isTableDisabled("randomTable5678"));<a name="line.417"></a>
+<span class="sourceLineNo">418</span>  }<a name="line.418"></a>
+<span class="sourceLineNo">419</span><a name="line.419"></a>
+<span class="sourceLineNo">420</span>  @Test<a name="line.420"></a>
+<span class="sourceLineNo">421</span>  public void testShutdownOfReplicaHolder() throws Exception {<a name="line.421"></a>
+<span class="sourceLineNo">422</span>    // checks that the when the server holding meta replica is shut down, the meta replica<a name="line.422"></a>
+<span class="sourceLineNo">423</span>    // can be recovered<a name="line.423"></a>
+<span class="sourceLineNo">424</span>    try (ClusterConnection conn = (ClusterConnection)<a name="line.424"></a>
+<span class="sourceLineNo">425</span>        ConnectionFactory.createConnection(TEST_UTIL.getConfiguration());) {<a name="line.425"></a>
+<span class="sourceLineNo">426</span>      RegionLocations rl = conn.<a name="line.426"></a>
+<span class="sourceLineNo">427</span>          locateRegion(TableName.META_TABLE_NAME, Bytes.toBytes(""), false, true);<a name="line.427"></a>
+<span class="sourceLineNo">428</span>      HRegionLocation hrl = rl.getRegionLocation(1);<a name="line.428"></a>
+<span class="sourceLineNo">429</span>      ServerName oldServer = hrl.getServerName();<a name="line.429"></a>
+<span class="sourceLineNo">430</span>      TEST_UTIL.getHBaseClusterInterface().killRegionServer(oldServer);<a name="line.430"></a>
+<span class="sourceLineNo">431</span>      int i = 0;<a name="line.431"></a>
+<span class="sourceLineNo">432</span>      do {<a name="line.432"></a>
+<span class="sourceLineNo">433</span>        LOG.debug("Waiting for the replica " + hrl.getRegionInfo() + " to come up");<a name="line.433"></a>
+<span class="sourceLineNo">434</span>        Thread.sleep(30000); //wait for the detection/recovery<a name="line.434"></a>
+<span class="sourceLineNo">435</span>        rl = conn.locateRegion(TableName.META_TABLE_NAME, Bytes.toBytes(""), false, true);<a name="line.435"></a>
+<span class="sourceLineNo">436</span>        hrl = rl.getRegionLocation(1);<a name="line.436"></a>
+<span class="sourceLineNo">437</span>        i++;<a name="line.437"></a>
+<span class="sourceLineNo">438</span>      } while ((hrl == null || hrl.getServerName().equals(oldServer)) &amp;&amp; i &lt; 3);<a name="line.438"></a>
+<span class="sourceLineNo">439</span>      assertTrue(i != 3);<a name="line.439"></a>
+<span class="sourceLineNo">440</span>    }<a name="line.440"></a>
+<span class="sourceLineNo">441</span>  }<a name="line.441"></a>
+<span class="sourceLineNo">442</span><a name="line.442"></a>
+<span class="sourceLineNo">443</span>  @Test<a name="line.443"></a>
+<span class="sourceLineNo">444</span>  public void testHBaseFsckWithExcessMetaReplicas() throws Exception {<a name="line.444"></a>
+<span class="sourceLineNo">445</span>    // Create a meta replica (this will be the 4th one) and assign it<a name="line.445"></a>
+<span class="sourceLineNo">446</span>    HRegionInfo h = RegionReplicaUtil.getRegionInfoForReplica(<a name="line.446"></a>
+<span class="sourceLineNo">447</span>        HRegionInfo.FIRST_META_REGIONINFO, 3);<a name="line.447"></a>
+<span class="sourceLineNo">448</span>    // create in-memory state otherwise master won't assign<a name="line.448"></a>
+<span class="sourceLineNo">449</span>    TEST_UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager()<a name="line.449"></a>
+<span class="sourceLineNo">450</span>             .getRegionStates().createRegionState(h);<a name="line.450"></a>
+<span class="sourceLineNo">451</span>    TEST_UTIL.getMiniHBaseCluster().getMaster().assignRegion(h);<a name="line.451"></a>
+<span class="sourceLineNo">452</span>    HBaseFsckRepair.waitUntilAssigned(TEST_UTIL.getHBaseAdmin(), h);<a name="line.452"></a>
+<span class="sourceLineNo">453</span>    // check that problem exists<a name="line.453"></a>
+<span class="sourceLineNo">454</span>    HBaseFsck hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.454"></a>
+<span class="sourceLineNo">455</span>    assertErrors(hbck, new ERROR_CODE[]{ERROR_CODE.UNKNOWN, ERROR_CODE.SHOULD_NOT_BE_DEPLOYED});<a name="line.455"></a>
+<span class="sourceLineNo">456</span>    // fix the problem<a name="line.456"></a>
+<span class="sourceLineNo">457</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), true);<a name="line.457"></a>
+<span class="sourceLineNo">458</span>    // run hbck again to make sure we don't see any errors<a name="line.458"></a>
+<span class="sourceLineNo">459</span>    hbck = doFsck(TEST_UTIL.getConfiguration(), false);<a name="line.459"></a>
+<span class="sourceLineNo">460</span>    assertErrors(hbck, new ERROR_CODE[]{});<a name="line.460"></a>
+<span class="sourceLineNo">461</span>  }<a name="line.461"></a>
+<span class="sourceLineNo">462</span>}<a name="line.462"></a>