You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/13 20:33:49 UTC

[GitHub] [beam] damccorm opened a new pull request, #25004: Use CC-BY image for custom remote inference notebook

damccorm opened a new pull request, #25004:
URL: https://github.com/apache/beam/pull/25004

   Updates the image used in the notebook and adds a line: `Note: all images are licensed CC-BY, creators are listed in the [LICENSE.txt](https://storage.googleapis.com/apache-beam-samples/image_captioning/LICENSE.txt) file.`
   
   ✨ [RENDERED](https://github.com/damccorm/beam/blob/1bfeb28d48c0c4c1984f815d24f21e013df1196f/examples/notebooks/beam-ml/custom_remote_inference.ipynb) ✨ 
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #25004: Use CC-BY image for custom remote inference notebook

Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #25004:
URL: https://github.com/apache/beam/pull/25004#issuecomment-1382437248

   I fixed that in my second commit, but the link in the description was pinned to the commit (the correct link is https://github.com/damccorm/beam/blob/users/damccorm/licensing/examples/notebooks/beam-ml/custom_remote_inference.ipynb)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rszper commented on pull request #25004: Use CC-BY image for custom remote inference notebook

Posted by GitBox <gi...@apache.org>.
rszper commented on PR #25004:
URL: https://github.com/apache/beam/pull/25004#issuecomment-1382437709

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #25004: Use CC-BY image for custom remote inference notebook

Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #25004:
URL: https://github.com/apache/beam/pull/25004#issuecomment-1382422995

   R: @rszper 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #25004: Use CC-BY image for custom remote inference notebook

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25004:
URL: https://github.com/apache/beam/pull/25004#issuecomment-1382425885

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm closed pull request #25004: Use CC-BY image for custom remote inference notebook

Posted by GitBox <gi...@apache.org>.
damccorm closed pull request #25004: Use CC-BY image for custom remote inference notebook
URL: https://github.com/apache/beam/pull/25004


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm merged pull request #25004: Use CC-BY image for custom remote inference notebook

Posted by GitBox <gi...@apache.org>.
damccorm merged PR #25004:
URL: https://github.com/apache/beam/pull/25004


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rszper commented on pull request #25004: Use CC-BY image for custom remote inference notebook

Posted by GitBox <gi...@apache.org>.
rszper commented on PR #25004:
URL: https://github.com/apache/beam/pull/25004#issuecomment-1382430216

   We also need to be sure to update the line preceding the image to describe the new image instead of the lion.
   
   Currently, it says: For example, the following image shows a lion with possible labels.
   
   We could change it to: For example, the following image shows a cat with possible captions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org