[jira] Commented: (LANG-52) [lang] Validate.notNull should throw NullArgumentException

["Henri Yandell (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/LANG-52?page=comments#action_12444520 ] 
            
Henri Yandell commented on LANG-52:
-----------------------------------

The only problem with this is in the messages. The NullArgumentException automatically adds " must not be null" to the end of any message passed up to it (ACK). In Validate we receive the message to print out, so having " must not be null" on the end becomes very daft. Credit to whomever wrote the unit tests that failed; otherwise I wouldn't have noticed.

We should also change the noNullElements methods if we do change the notNull ones, but I think the gain here is not worth the pain.

I'm +1 to WONTFIX this.

> [lang] Validate.notNull should throw NullArgumentException
> ----------------------------------------------------------
>
>                 Key: LANG-52
>                 URL: http://issues.apache.org/jira/browse/LANG-52
>             Project: Commons Lang
>          Issue Type: Bug
>         Environment: Operating System: All
> Platform: All
>            Reporter: Jörg Gottschling
>            Priority: Trivial
>             Fix For: 3.0
>
>
> Validate.notNull throws a IllegalArgumentException but should throw a
> NullArgumentException

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org