You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Bill Dudney (JIRA)" <de...@geronimo.apache.org> on 2006/03/03 22:02:41 UTC
[jira] Created: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
--------------------------------------------------
Key: GERONIMO-1686
URL: http://issues.apache.org/jira/browse/GERONIMO-1686
Project: Geronimo
Type: New Feature
Reporter: Bill Dudney
Priority: Minor
I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Matt Hogstrom (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=all ]
Matt Hogstrom updated GERONIMO-1686:
------------------------------------
Fix Version/s: 2.0
(was: 1.2)
Moving to 2.0 as its Java EE 5.0 related.
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: specs
> Reporter: Bill Dudney
> Assigned To: Jeff Genender
> Priority: Minor
> Fix For: 2.0
>
> Attachments: geronimo-spec-servlet-2.5.patch, jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12369643 ]
Jeff Genender commented on GERONIMO-1686:
-----------------------------------------
About the ASL 2.0 in the XSDs, I think those need to be verbatim with out additionally adding the ASF license to them. Of many the XSDs I have seen, I have not found the ASL 2.0 in them.
Also several of the web-app*.xsd and dtds already included with Geornimo specs have the Sun copyright in them. If it is not legal to use them, then we need to do something about all the other specs' use of the dtds and xsds as many of them contain the Sun copyright.
We really need an official comment on this. Perhaps I will bring it up in legal@a.o.
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Bill Dudney (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=all ]
Bill Dudney updated GERONIMO-1686:
----------------------------------
Attachment: jee5_exp.patch
apply at the root of http://svn.apache.org/repos/asf/geronimo/specs/branches/jee5_exp
with 'patch -p0 < ./jee5_exp.patch'
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Priority: Minor
> Attachments: jee5_exp.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12369642 ]
Jacek Laskowski commented on GERONIMO-1686:
-------------------------------------------
I'm not and was happy to see you working on it due to the issues I described ;)
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=all ]
Jeff Genender reassigned GERONIMO-1686:
---------------------------------------
Assign To: Jeff Genender
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370808 ]
Greg Wilkins commented on GERONIMO-1686:
----------------------------------------
> * GenericServlet calls super() when it does not need to.
> More specifics would be good here. I've changed the code though to look more like the <= 2.4 code which could clear things up.
super() is called by default anyway... so it is just not needed.
> * In GenericServlet, the initParameter, getServletContext and getServletName
> methods are now all protected with an IllegalStateException if the ServletConfig is null (ie if init(ServletConfig) has been overriden and does not call > super).
> This is mandated by the spec now.
> I could not find anywhere in the 2.5 spec that spelled this out. However I totally agree that IllegalStateException is much better than
> NullPointerException so I updated the code to throw ISE instead of NPE. If you could point me to the spec bits that specify this I'd be glad to make
> sure the spec is being followed.
I'm not sure if the version that mandates it is released. Besides I think it is specified in the javadoc rather than the spec itself.
> * geronimo is using @override and @deprecated which I think is needless java5 featurism (I know java5 is required for compliance.... but there is nothing in the rest of the javax classes that needs it).
>
> Does it matter one way or the other? I'm fine either way. Unchanged in this patch.
It stops this source being used for 1.4 based servlet containers... when there is no need to. I don't think these
anotations add enough value to make that worthwhile (yet).
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Prasad Kashyap (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Kashyap updated GERONIMO-1686:
-------------------------------------
Patch Info: [Patch Available]
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: https://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: specs
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Fix For: 2.0
>
> Attachments: geronimo-spec-servlet-2.5.patch, jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Bill Dudney (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=all ]
Bill Dudney updated GERONIMO-1686:
----------------------------------
Attachment: jee5_exp_servlet.patch
the jee5_exp_servlet.patch is the patch to use to add servlet 2.5 to the jee5 spec project.
this patch contains the LICENSE.txt and NOTICE.txt files as well as a verbatim copy of the xsd from
the servlet spec pdf.
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517795 ]
Greg Wilkins commented on GERONIMO-1686:
----------------------------------------
Jetty has switched to directly using the source checked out from the reference impl (glassfish)
Doing a diff with the latest from geronimo, the only differences appear to be the licence headers and
some handling of resource files.
So I think this issue can be closed.
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: https://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: specs
> Affects Versions: 2.0
> Reporter: Bill Dudney
> Assignee: Greg Wilkins
> Priority: Minor
> Fix For: Wish List
>
> Attachments: geronimo-spec-servlet-2.5.patch, jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=all ]
Dain Sundstrom updated GERONIMO-1686:
-------------------------------------
Component: specs
Fix Version: 1.2
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Security: public(Regular issues)
> Components: specs
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Fix For: 1.2
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Bill Dudney (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370336 ]
Bill Dudney commented on GERONIMO-1686:
---------------------------------------
Hi Jeff,
The JSP stuff is still about a week out. I have a bunch of TestNG code that I have to either drop or convert to JUnit before making the commit. And I've not had time to go through the code with the spec and check all the method signatures.
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12369639 ]
Jacek Laskowski commented on GERONIMO-1686:
-------------------------------------------
What put me off committing it was the license in src/main/resources/javax/servlet/resources/web-app_2_3.dtd. Are we allowed to have it in our repo? The module/j2ee-schema contains such files too, so it could imply we are, but am not so certain as I wish to. Sent a question to the dev mailing list. Awaiting response...
Other (important) notes:
* Use Rev keyword rather than Revision in the header (run svn propset -R svn:keywords 'Rev Date')
* LICENSE.txt and NOTICE.txt are mandatory
* Use ASL 2.0 in all of the files (xml's too) - no complaints allowed that the other specs miss them too ;)
* No need to specify settings which are (supposed to be) specified in the parent pom (cf. scm). Unless it is already, patch the parent pom
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Priority: Minor
> Attachments: jee5_exp.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Prasad Kashyap (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Kashyap updated GERONIMO-1686:
-------------------------------------
Fix Version/s: (was: 2.0-M5)
2.0
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: https://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: specs
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Fix For: 2.0
>
> Attachments: geronimo-spec-servlet-2.5.patch, jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370415 ]
Greg Wilkins commented on GERONIMO-1686:
----------------------------------------
I've done some comparisons of the javax.servlet classes from geronimo to those in jetty6.
The Jetty 6 classes are the apache 1.1 licensed ones from an early version of glassfish to which I have manually applied the subsequent changes.
As there are many many differences (not least the order of messages), I have
stripped comments from my diffs. However, many of the changes in the 2.5 spec have been in the javadoc.
Differences that I have spotted so far are:
* Geronimo classes do not use resource bundles for messages.
* GenericServlet calls super() when it does not need to.
* In GenericServlet, the initParameter, getServletContext and getServletName
methods are now all protected with an IllegalStateException if the ServletConfig is null (ie if init(ServletConfig) has been overriden and does not call super).
This is mandated by the spec now.
* Cookie in geronimo does not default maxAge to -1
* Cookie.clone() in geronimo does not call super.clone()... which I think is bad???
* geronimo is using @override and @deprecated which I think is needless java5 featurism (I know java5 is required for compliance.... but there is nothing in the rest of the javax classes that needs it).
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370806 ]
Greg Wilkins commented on GERONIMO-1686:
----------------------------------------
Note that the jasper folks have already done the JSP API:
http://svn.apache.org/repos/asf/tomcat/jasper/tc6.0.x/src/share/javax
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=all ]
Greg Wilkins updated GERONIMO-1686:
-----------------------------------
Attachment: geronimo-spec-servlet-2.5.patch
This patch adds jetty version of the javax.servlet API to the main geronimo spec repo.
While much work has been done typing in the 2.5 specification, this lacks the javadoc which is a vital part of the specification. Thus I think we need a better version.
The Jetty version has the following history:
1) copied from the apache 2.0 licenced jakarta 2.4 files
2) patched to 2.5 by comparison to the apache licensed glassfish 2.5 files (before they
were converted to a sun license (how can they do that?)).
3) manually maintained by monitoring posts to the servlet JSR EG group.
The javadoc in these files is probably not perfect... but it is close.
I think the history above makes these legal - although it may be better eventually to get the jars from tomcat 6?
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Security: public(Regular issues)
> Components: specs
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Fix For: 1.2
> Attachments: geronimo-spec-servlet-2.5.patch, jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370316 ]
Jeff Genender commented on GERONIMO-1686:
-----------------------------------------
Nice work. But I only see the servlet side of things, not JSPs. nevertheless I committed the servlet work. Good job. please advise about the JSPs.
Adding geronimo-spec-servlet
Adding geronimo-spec-servlet/LICENSE.txt
Adding geronimo-spec-servlet/NOTICE.txt
Adding geronimo-spec-servlet/pom.xml
Adding geronimo-spec-servlet/src
Adding geronimo-spec-servlet/src/main
Adding geronimo-spec-servlet/src/main/java
Adding geronimo-spec-servlet/src/main/java/javax
Adding geronimo-spec-servlet/src/main/java/javax/servlet
Adding geronimo-spec-servlet/src/main/java/javax/servlet/Filter.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/FilterChain.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/FilterConfig.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/GenericServlet.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/RequestDispatcher.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/Servlet.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletConfig.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletContext.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletContextAttributeEvent.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletContextAttributeListener.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletContextEvent.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletContextListener.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletException.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletInputStream.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletOutputStream.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletRequest.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletRequestAttributeEvent.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletRequestAttributeListener.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletRequestEvent.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletRequestListener.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletRequestWrapper.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletResponse.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/ServletResponseWrapper.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/SingleThreadedModel.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/UnavailableException.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/Cookie.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpServlet.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpServletRequest.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpServletRequestWrapper.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpServletResponse.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpServletResponseWrapper.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpSession.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpSessionActivationListener.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpSessionAttributeListener.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpSessionBindingEvent.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpSessionBindingListener.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpSessionContext.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpSessionEvent.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpSessionListener.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/HttpUtils.java
Adding geronimo-spec-servlet/src/main/java/javax/servlet/http/LocalStrings.properties
Adding geronimo-spec-servlet/src/main/resources
Adding geronimo-spec-servlet/src/main/resources/javax
Adding geronimo-spec-servlet/src/main/resources/javax/servlet
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/XMLSchema.dtd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/datatypes.dtd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/j2ee_1_4.xsd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/j2ee_web_services_1_1.xsd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/j2ee_web_services_client_1_1.xsd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/web-app_2_2.dtd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/web-app_2_3.dtd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/web-app_2_4.xsd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/web-app_2_5.xsd
Adding geronimo-spec-servlet/src/main/resources/javax/servlet/resources/xml.xsd
Sending pom.xml
Transmitting file data .......................................................
Committed revision 385750.
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Bill Dudney (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12369644 ]
Bill Dudney commented on GERONIMO-1686:
---------------------------------------
Hi Jacek & Jeff,
I'm happy to go back and change Revesion to Rev, I did Revision cause that is what was in the other files in this branch.
Forgot LICENSE.txt and NOTICE.txt, will add those in another attachement in a second...
I used ASL 2.0 on all files I wrote, others were copied out of the older specs (as mentioned in the dev@G) thread so I did not want to change them. I'm happy to go back and do so though.
Ah yes the scm settings, copy paste error from parent pom. I'd be glad to nuke that from the patch and resubmit.
Let me know.
Thanks,
-bd-
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Bill Dudney (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12369637 ]
Bill Dudney commented on GERONIMO-1686:
---------------------------------------
this is the patch for servlet api, i'll be providing the jsp one shortly
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Priority: Minor
> Attachments: jee5_exp.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Bill Dudney (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370815 ]
Bill Dudney commented on GERONIMO-1686:
---------------------------------------
Hi Greg,
Make sure you are using the 3rd patch (its about 13 K) instead of the other two which are substantially larger.
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated GERONIMO-1686:
-----------------------------------
Affects Version/s: 2.0
Fix Version/s: (was: 2.0)
Wish List
Assignee: Greg Wilkins (was: Jeff Genender)
Greg, if you think this is important you should take the initiative and commit your changes :-).
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: https://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: specs
> Affects Versions: 2.0
> Reporter: Bill Dudney
> Assignee: Greg Wilkins
> Priority: Minor
> Fix For: Wish List
>
> Attachments: geronimo-spec-servlet-2.5.patch, jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Bill Dudney (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=all ]
Bill Dudney updated GERONIMO-1686:
----------------------------------
Attachment: servlet_fixes.patch
Hi Greg,
Thanks for testing the stuff out so quickly! I've put some comments into the issues below;
To apply this patch you have to use the -E option to patch i.e.
jee5_exp $ patch -E -p0 ./servlet_fixes.patch
Once the patch is fixed the renaming of SingleThreadedModel.java to SingleThreadModel.java is done but the patch does not do the svn del and svn add so that will have to be done by hand.
Thanks again Greg. My comments are inlined here...
* Geronimo classes do not use resource bundles for messages.
The G classes do use resource bundles but not in javax.servlet only in javax.servlet.http. The <= 2.4 code used resource bundles to internationalize 'true' and 'false' and a ISO character problem. I did not think we needed resource bundles to manage 'true' and 'false' and the ISO character problem was related to the 'old' way to do conversion. I updated to use JDK 1.4 classes and code so I'd expect that the internationalization is managed by JDK classes so we don't need that either.
In javax.servlet.http I missed Cookie.java and fixed it with this patch.
* GenericServlet calls super() when it does not need to.
More specifics would be good here. I've changed the code though to look more like the <= 2.4 code which could clear things up.
* In GenericServlet, the initParameter, getServletContext and getServletName
methods are now all protected with an IllegalStateException if the ServletConfig is null (ie if init(ServletConfig) has been overriden and does not call super).
This is mandated by the spec now.
I could not find anywhere in the 2.5 spec that spelled this out. However I totally agree that IllegalStateException is much better than NullPointerException so I updated the code to throw ISE instead of NPE. If you could point me to the spec bits that specify this I'd be glad to make sure the spec is being followed.
* Cookie in geronimo does not default maxAge to -1
Fixed in this patch.
* Cookie.clone() in geronimo does not call super.clone()... which I think is bad???
Changed it anyway to call super.clone();
* geronimo is using @override and @deprecated which I think is needless java5 featurism (I know java5 is required for compliance.... but there is nothing in the rest of the javax classes that needs it).
Does it matter one way or the other? I'm fine either way. Unchanged in this patch.
* HttpServletRequestWrapper getRequest() returns HttpServletRequest. I think this should be ServletRequest.
Good point - fixed
* ServletResponse.getWriter should return PrintWriter not Writer.
Another fix
* ServletRequestListener does not implements EventListener
Another fix
* ServletContext.getServlet(String) does not throw ServletException
Another fix
javax/servlet/SingleThreadedModel.java should be javax/servlet/SingleThreadModel.java
Good point, fixed
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370810 ]
Greg Wilkins commented on GERONIMO-1686:
----------------------------------------
Mmmm having hassles applying patch with or without the -E
I'm ending up with two copies of each class in every java file???
The patch looks to have the complete source in it, with no - or changed lines?
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars for
JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Wilkins closed GERONIMO-1686.
----------------------------------
Resolution: Fixed
changes appear to have been merged via other paths.
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: https://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Components: specs
> Affects Versions: 2.0
> Reporter: Bill Dudney
> Assignee: Greg Wilkins
> Priority: Minor
> Fix For: Wish List
>
> Attachments: geronimo-spec-servlet-2.5.patch, jee5_exp.patch, jee5_exp_servlet.patch, servlet_fixes.patch
>
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370425 ]
Greg Wilkins commented on GERONIMO-1686:
----------------------------------------
Note... I'm not applying these changes.... as I'm not sure that it is correct for me to do so
while looking at 1.1 licensed source.
anyway... some more differences:
HttpServletRequestWrapper getRequest() returns HttpServletRequest. I think this should be ServletRequest.
ServletResponse.getWriter should return PrintWriter not Writer.
ServletRequestListener does not implements EventListener
ServletContext.getServlet(String) does not throw ServletException
I also built a version for Jetty 6 and ran my tests against it without problem (once I
fixed some of these issues).
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Greg Wilkins (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370491 ]
Greg Wilkins commented on GERONIMO-1686:
----------------------------------------
javax/servlet/SingleThreadedModel.java should be javax/servlet/SingleThreadModel.java
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch, jee5_exp_servlet.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars
for JavaEE 5 work
Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12369640 ]
Jeff Genender commented on GERONIMO-1686:
-----------------------------------------
Whoops, I took the assignment without reading what Jacek said...and didn't see that he already took a gander at it...
> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
> Key: GERONIMO-1686
> URL: http://issues.apache.org/jira/browse/GERONIMO-1686
> Project: Geronimo
> Type: New Feature
> Reporter: Bill Dudney
> Assignee: Jeff Genender
> Priority: Minor
> Attachments: jee5_exp.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira