[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #9078: Wrap tagging endpoints in a feature flag (disabled by default)

[GitBox <gi...@apache.org>]

craig-rueda commented on a change in pull request #9078: Wrap tagging endpoints in a feature flag (disabled by default)
URL: https://github.com/apache/incubator-superset/pull/9078#discussion_r374364804
 
 

 ##########
 File path: superset/app.py
 ##########
 @@ -277,7 +277,9 @@ def init_views(self) -> None:
         appbuilder.add_view_no_menu(TableModelView)
         appbuilder.add_view_no_menu(TableSchemaView)
         appbuilder.add_view_no_menu(TabStateView)
-        appbuilder.add_view_no_menu(TagView)
+
+        if feature_flag_manager.is_feature_enabled("TAGGING_ENDPOINTS"):
 
 Review comment:
   Would be great to add a test for this, although it's not trivial to do so with our current testing setup :,(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org