You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/08/29 01:52:54 UTC
[GitHub] [trafficcontrol] mitchell852 commented on a diff in pull request #7042: Enables the use of "offline reason" for all statuses not ONLINE/REPORTED
mitchell852 commented on code in PR #7042:
URL: https://github.com/apache/trafficcontrol/pull/7042#discussion_r956834910
##########
traffic_ops/traffic_ops_golang/server/put_status.go:
##########
@@ -121,7 +121,7 @@ func UpdateStatusHandler(w http.ResponseWriter, r *http.Request) {
return
}
- if *status.Name == tc.CacheStatusAdminDown.String() || *status.Name == tc.CacheStatusOffline.String() {
+ if *status.Name != tc.CacheStatusOnline.String() && *status.Name != tc.CacheStatusReported.String() {
if reqObj.OfflineReason == nil {
Review Comment:
this actually makes offline reason required for a bunch of statuses so if this is a breaking api change, i will just hold off until api 5.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org