You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jimmy Xiang <jx...@apache.org> on 2015/11/19 21:53:22 UTC
Review Request 40500: HIVE-12338 Add webui to HiveServer2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/
-----------------------------------------------------------
Review request for hive, Szehon Ho and Xuefu Zhang.
Bugs: HIVE-12338
https://issues.apache.org/jira/browse/HIVE-12338
Repository: hive-git
Description
-------
Added web UI to HS2. The UI is similar to those for other Hadoop components.
The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
Diffs
-----
common/pom.xml cd14581
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
pom.xml c6df4a5
service/pom.xml afa52cf
service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
Diff: https://reviews.apache.org/r/40500/diff/
Testing
-------
Thanks,
Jimmy Xiang
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107938
-----------------------------------------------------------
Ship it!
Ship It!
- Lefty Leverenz
On Nov. 24, 2015, 7:36 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 7:36 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fffedd9
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c38c10f
> ql/pom.xml d893099
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 25cefc2
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 1331a99
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java a14908b
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
> spark-client/pom.xml 9d2b418
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Jimmy Xiang <jx...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 7:36 p.m.)
Review request for hive, Szehon Ho and Xuefu Zhang.
Bugs: HIVE-12338
https://issues.apache.org/jira/browse/HIVE-12338
Repository: hive-git
Description
-------
Added web UI to HS2. The UI is similar to those for other Hadoop components.
The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
Diffs (updated)
-----
common/pom.xml cd14581
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fffedd9
common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
pom.xml c38c10f
ql/pom.xml d893099
service/pom.xml afa52cf
service/src/java/org/apache/hive/service/cli/operation/Operation.java 25cefc2
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 1331a99
service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java a14908b
service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
spark-client/pom.xml 9d2b418
Diff: https://reviews.apache.org/r/40500/diff/
Testing
-------
Thanks,
Jimmy Xiang
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Jimmy Xiang <jx...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 9:51 p.m.)
Review request for hive, Szehon Ho and Xuefu Zhang.
Bugs: HIVE-12338
https://issues.apache.org/jira/browse/HIVE-12338
Repository: hive-git
Description
-------
Added web UI to HS2. The UI is similar to those for other Hadoop components.
The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
Diffs (updated)
-----
common/pom.xml cd14581
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f48403b
common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
pom.xml c6df4a5
ql/pom.xml 9420a62
service/pom.xml afa52cf
service/src/java/org/apache/hive/service/cli/operation/Operation.java 25cefc2
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 1331a99
service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java a14908b
service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
spark-client/pom.xml a0bbe56
Diff: https://reviews.apache.org/r/40500/diff/
Testing
-------
Thanks,
Jimmy Xiang
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Jimmy Xiang <jx...@apache.org>.
> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > LGTM. This patch only includes SQLOperations. Are we planning to add metadata operations as well ? (so we can capture jdbc clients and Hue usage as well...)
Thanks a lot for the review. I was thinking about showing meta operations in HMS web UI. Should we also show them here?
> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1856
> > <https://reviews.apache.org/r/40500/diff/1/?file=1133028#file1133028line1856>
> >
> > Th -> The
Good catch. Fixed.
> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java, line 66
> > <https://reviews.apache.org/r/40500/diff/1/?file=1133036#file1133036line66>
> >
> > any reason we only want sqloperations ?
No special reason. SQLOperations are interesting to show for HS2. Hive commands are quick to run. Meta operations, should we show them in HMS web ui?
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107283
-----------------------------------------------------------
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:53 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c6df4a5
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Jimmy Xiang <jx...@apache.org>.
> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > LGTM. This patch only includes SQLOperations. Are we planning to add metadata operations as well ? (so we can capture jdbc clients and Hue usage as well...)
>
> Jimmy Xiang wrote:
> Thanks a lot for the review. I was thinking about showing meta operations in HMS web UI. Should we also show them here?
>
> Mohit Sabharwal wrote:
> I guess at some point it'd be good to have it in HS2 UI as well so we can get the end-to-end picture (That way we can show all running operations for a given session, not just the queries). We could do this as an enhancement at a later point.
Right. It is nice to have to get an end-to-end picture. Let's do it as a followup enhancement.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107283
-----------------------------------------------------------
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:53 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c6df4a5
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Mohit Sabharwal <mo...@cloudera.com>.
> On Nov. 20, 2015, 4:53 a.m., Mohit Sabharwal wrote:
> > LGTM. This patch only includes SQLOperations. Are we planning to add metadata operations as well ? (so we can capture jdbc clients and Hue usage as well...)
>
> Jimmy Xiang wrote:
> Thanks a lot for the review. I was thinking about showing meta operations in HMS web UI. Should we also show them here?
I guess at some point it'd be good to have it in HS2 UI as well so we can get the end-to-end picture (That way we can show all running operations for a given session, not just the queries). We could do this as an enhancement at a later point.
- Mohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107283
-----------------------------------------------------------
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:53 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c6df4a5
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107283
-----------------------------------------------------------
LGTM. This patch only includes SQLOperations. Are we planning to add metadata operations as well ? (so we can capture jdbc clients and Hue usage as well...)
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1856)
<https://reviews.apache.org/r/40500/#comment166319>
Th -> The
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java (line 65)
<https://reviews.apache.org/r/40500/#comment166342>
any reason we only want sqloperations ?
- Mohit Sabharwal
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:53 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c6df4a5
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Jimmy Xiang <jx...@apache.org>.
> On Nov. 21, 2015, 5:11 a.m., Lefty Leverenz wrote:
> >
Good catches. Thanks a lot for the review.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107474
-----------------------------------------------------------
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:53 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c6df4a5
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Lefty Leverenz <le...@gmail.com>.
> On Nov. 21, 2015, 5:11 a.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hive/http/JMXJsonServlet.java, line 252
> > <https://reviews.apache.org/r/40500/diff/1/?file=1133032#file1133032line252>
> >
> > "exceptionscan" -> "exception scan"
Thanks for fixing it the way I meant ... exceptions can, not exception scan. (Snicker.)
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107474
-----------------------------------------------------------
On Nov. 24, 2015, 7:36 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 7:36 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fffedd9
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c38c10f
> ql/pom.xml d893099
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java 25cefc2
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 1331a99
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java a14908b
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
> spark-client/pom.xml 9d2b418
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107474
-----------------------------------------------------------
common/src/java/org/apache/hive/http/HttpServer.java (line 114)
<https://reviews.apache.org/r/40500/#comment166577>
"check that if" should be "check if"
common/src/java/org/apache/hive/http/HttpServer.java (line 139)
<https://reviews.apache.org/r/40500/#comment166578>
"Does the user ... has" should be "Does the user ... have"
common/src/java/org/apache/hive/http/JMXJsonServlet.java (line 69)
<https://reviews.apache.org/r/40500/#comment166579>
"hadoop" should be "Hadoop"
common/src/java/org/apache/hive/http/JMXJsonServlet.java (line 71)
<https://reviews.apache.org/r/40500/#comment166580>
"an specific" -> "a specific"
common/src/java/org/apache/hive/http/JMXJsonServlet.java (line 83)
<https://reviews.apache.org/r/40500/#comment166581>
"resouce" -> "resource"
"a mbean" -> "an mbean"
common/src/java/org/apache/hive/http/JMXJsonServlet.java (line 99)
<https://reviews.apache.org/r/40500/#comment166582>
"the the"
common/src/java/org/apache/hive/http/JMXJsonServlet.java (line 252)
<https://reviews.apache.org/r/40500/#comment166583>
"exceptionscan" -> "exception scan"
- Lefty Leverenz
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:53 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c6df4a5
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Jimmy Xiang <jx...@apache.org>.
> On Nov. 23, 2015, 9:37 p.m., Szehon Ho wrote:
> > service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp, line 168
> > <https://reviews.apache.org/r/40500/diff/1/?file=1133042#file1133042line168>
> >
> > One more comment, no need to put 'version', just 'When Hive version was compiled and by whom'
Already fixed in v2. Let me upload it here.
> On Nov. 23, 2015, 9:37 p.m., Szehon Ho wrote:
> > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java, line 66
> > <https://reviews.apache.org/r/40500/diff/1/?file=1133036#file1133036line66>
> >
> > What do you think about having jsp code filter out operation that are not SQLOperation?
> >
> > Seems cleaner than maintaining a separate list in here.
We can address this in HIVE-12484. The other option is to show all operations instead of just SQL queries. We can discuss it there.
> On Nov. 23, 2015, 9:37 p.m., Szehon Ho wrote:
> > common/pom.xml, line 61
> > <https://reviews.apache.org/r/40500/diff/1/?file=1133027#file1133027line61>
> >
> > Indent
Cool. Will fix it.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107271
-----------------------------------------------------------
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:53 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c6df4a5
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>
Re: Review Request 40500: HIVE-12338 Add webui to HiveServer2
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40500/#review107271
-----------------------------------------------------------
common/pom.xml (line 61)
<https://reviews.apache.org/r/40500/#comment166298>
Indent
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1856)
<https://reviews.apache.org/r/40500/#comment166299>
Typo
service/src/java/org/apache/hive/service/cli/operation/OperationManager.java (line 65)
<https://reviews.apache.org/r/40500/#comment166873>
What do you think about having jsp code filter out operation that are not SQLOperation?
Seems cleaner than maintaining a separate list in here.
service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp (line 168)
<https://reviews.apache.org/r/40500/#comment166304>
One more comment, no need to put 'version', just 'When Hive version was compiled and by whom'
- Szehon Ho
On Nov. 19, 2015, 8:53 p.m., Jimmy Xiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40500/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 8:53 p.m.)
>
>
> Review request for hive, Szehon Ho and Xuefu Zhang.
>
>
> Bugs: HIVE-12338
> https://issues.apache.org/jira/browse/HIVE-12338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added web UI to HS2. The UI is similar to those for other Hadoop components.
> The default web UI port is set to 10002, which is configurable. It can be disabled. Currently it shows active sessions and queries. It can also access locals, metrics, and configuration.
>
>
> Diffs
> -----
>
> common/pom.xml cd14581
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85
> common/src/java/org/apache/hive/http/AdminAuthorizedServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/ConfServlet.java PRE-CREATION
> common/src/java/org/apache/hive/http/HttpServer.java PRE-CREATION
> common/src/java/org/apache/hive/http/JMXJsonServlet.java PRE-CREATION
> pom.xml c6df4a5
> service/pom.xml afa52cf
> service/src/java/org/apache/hive/service/cli/operation/Operation.java d13415e
> service/src/java/org/apache/hive/service/cli/operation/OperationManager.java b0bd351
> service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 8b42265
> service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java 1ab5652
> service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 2d784f0
> service/src/java/org/apache/hive/service/cli/session/SessionManager.java d11cf3d
> service/src/java/org/apache/hive/service/server/HiveServer2.java b30b6a2
> service/src/resources/hive-webapps/hiveserver2/hiveserver2.jsp PRE-CREATION
> service/src/resources/hive-webapps/hiveserver2/index.html PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap-theme.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/bootstrap.min.css PRE-CREATION
> service/src/resources/hive-webapps/static/css/hive.css PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.eot PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.svg PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.ttf PRE-CREATION
> service/src/resources/hive-webapps/static/fonts/glyphicons-halflings-regular.woff PRE-CREATION
> service/src/resources/hive-webapps/static/hive_logo.jpeg PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40500/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jimmy Xiang
>
>