You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2025/02/25 19:22:50 UTC

[PR] RATIS-2252. Update JUnitRunListener with junit 5. [ratis]

szetszwo opened a new pull request, #1228:
URL: https://github.com/apache/ratis/pull/1228

   ## What changes were proposed in this pull request?
   
   Update JUnitRunListener with junit 5.
   
   ## What is the link to the Apache JIRA
   
   RATIS-2252
   
   Please replace this section with the link to the Apache JIRA)
   
   ## How was this patch tested?
   
   Tested manually using the following code in ratis-common and ratis-example.
   ```java
   public class TestJUnit5TestExecutionListener2 {
     @Timeout(value = 1)
     @Test
     public void testNoTimeout() throws Exception {
     }
   
     @Timeout(value = 1, unit = TimeUnit.MILLISECONDS)
     @Test
     public void testTimeout() throws Exception {
       Thread.sleep(100);
     }
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2252. Update JUnitRunListener with junit 5. [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #1228:
URL: https://github.com/apache/ratis/pull/1228


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2252. Update JUnitRunListener with junit 5. [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1228:
URL: https://github.com/apache/ratis/pull/1228#issuecomment-2685524619

   @slfan1989 , @adoroszlai , thanks a lot for reviewing this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2252. Update JUnitRunListener with junit 5. [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1228:
URL: https://github.com/apache/ratis/pull/1228#issuecomment-2684243201

   Thanks @slfan1989 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2252. Update JUnitRunListener with junit 5. [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1228:
URL: https://github.com/apache/ratis/pull/1228#issuecomment-2683324756

   TestRaftWithGrpc.testWithLoad(boolean)[2] failed with timeout in the previous run.  Checked the log, it does have the thread dump.
   - https://github.com/apache/ratis/actions/runs/13530776533/job/37812219666?pr=1228#step:11:923


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org