You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2016/01/12 21:42:24 UTC
[GitHub] storm pull request: STORM-1467: Switch apache-rat plugin off by de...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/1006
STORM-1467: Switch apache-rat plugin off by default, but enable for Travis-CI
I added an un-licensed file in to show that the CI will fail. I'll remove it before merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-1467
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1006.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1006
----
commit 4c2b17c0a4fef0d91a3bc661f8af748ceb527d2b
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-01-12T17:58:07Z
Testing.
commit a723485272ff689abd4305d17bc46fe32a6490e0
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-01-12T18:00:28Z
Testing.
commit d43b64cf7aaeb37867f425d973170e4fa8c92244
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-01-12T18:17:18Z
Adding dumb file for the rat to find.
commit e34db41cc93be24dee41bf2e66937d4031ab4ccc
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-01-12T20:29:32Z
Testing.
commit 99ea06fb1e9b1b2114d860198368c31775b4344e
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-01-12T20:40:57Z
Fix & Test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1467: Switch apache-rat plugin off by de...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1006#issuecomment-171056928
I really would prefer to see this be a part of a profile. So we can turn it on with something like `-Prat`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1467: Switch apache-rat plugin off by de...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1006#issuecomment-171366113
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---