You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/24 12:00:21 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #3834: Fix: The
metrics view API response is not super-set of resources response keys
Pearl1594 opened a new pull request #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834
## Description
The metrics API has few properties missing that are present in the corresponding resource. This addressed the following issue: https://github.com/apache/cloudstack/issues/3831
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578144769
@DaanHoogland my suggestion is, we can use lombok.
https://projectlombok.org/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Pearl1594 opened a new pull request #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
Pearl1594 opened a new pull request #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834
## Description
The metrics API has few properties missing that are present in the corresponding resource. This addressed the following issue: https://github.com/apache/cloudstack/issues/3831
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-579634349
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Pearl1594 commented on issue #3834: Fix: The metrics
view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578158007
@DaanHoogland I've reverted the particular function to it's original naming convention. the getter function need not be modified for this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578624809
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-579680117
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-579640885
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-681
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578616183
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578132450
I do not care much either way but we agreed on the getter convention for booleans a while back. thoughts @rhtyd ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-579642246
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578622236
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-658
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578165569
That's how BeanUtils::copyProperties and most IDEs works. The problem of booleans having `is` than `get` breaks the use case to copy bean/properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578616167
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Pearl1594 opened a new pull request #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
Pearl1594 opened a new pull request #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834
## Description
The metrics API has few properties missing that are present in the corresponding resource. This addressed the following issue: https://github.com/apache/cloudstack/issues/3831
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578146630
@weizhouapache looks cool. @Pearl1594 @rhtyd is there a specific reason to go back on our getter convention, or any other reason we shouldn't use lombok? (name of the neightbourhood I live in;) after the indonesian isleland \o/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-579679990
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-579969635
<b>Trillian test result (tid-836)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39519 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3834-t836-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request
#3834: Fix: The metrics view API response is not super-set of resources
response keys
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#discussion_r370635191
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/VolumeResponse.java
##########
@@ -293,7 +293,7 @@ public String getObjectId() {
return this.getId();
}
- public Boolean isDestroyed() {
+ public Boolean getDestroyed() {
Review comment:
boolean getter should adhere to is<attr>() pattern
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache edited a comment on issue #3834: Fix:
The metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578144769
@DaanHoogland my suggestion is, we can use lombok.
https://projectlombok.org/
https://projectlombok.org/features/GetterSetter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-579634488
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578625063
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3834: Fix: The
metrics view API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578157613
@Pearl1594 @rhtyd can you meddle in on @weizhouapache 's idea? (lombok would actually make this a get<>() as it is Boolean and not boolean)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3834: Fix: The metrics view
API response is not super-set of resources response keys
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3834: Fix: The metrics view API response is not super-set of resources response keys
URL: https://github.com/apache/cloudstack/pull/3834#issuecomment-578167146
@DaanHoogland this is a special case for the metrics apis that extend over resource list apis. Without using getters instead of issers, it cannot be fixed. Turns out the previously referred agreement is merely our own preference but not a standard convention for IDEs, and libraries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services