You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/07/15 19:59:54 UTC

Review Request 23510: Fix docker usage unit test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23510/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Yifan Gu.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

The Docker usage test breaks since we launch a Docker with given resource limits but when we test usage it will get different limits as Docker update changes it afterwards.
This fix mocks out Docker update and ignore all Update calls so it has the same resource limits.


Diffs
-----

  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23510/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Re: Review Request 23510: Fix docker usage unit test

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23510/#review47881
-----------------------------------------------------------


Bad patch!

Reviews applied: [23510]

Failed command: git apply --index 23510.patch

Error:
 error: src/tests/docker_containerizer_tests.cpp: does not exist in index


- Mesos ReviewBot


On July 15, 2014, 5:59 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23510/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 5:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Yifan Gu.
> 
> 
> Bugs: MESOS-1524
>     https://issues.apache.org/jira/browse/MESOS-1524
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The Docker usage test breaks since we launch a Docker with given resource limits but when we test usage it will get different limits as Docker update changes it afterwards.
> This fix mocks out Docker update and ignore all Update calls so it has the same resource limits.
> 
> 
> Diffs
> -----
> 
>   src/tests/docker_containerizer_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23510/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 23510: Fix docker usage unit test

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23510/#review48031
-----------------------------------------------------------


Bad patch!

Reviews applied: [23490]

Failed command: git apply --index 23490.patch

Error:
 error: src/docker/docker.hpp: does not exist in index
error: src/docker/docker.cpp: does not exist in index
error: src/slave/containerizer/docker.cpp: does not exist in index


- Mesos ReviewBot


On July 17, 2014, 6:17 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23510/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 6:17 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Yifan Gu.
> 
> 
> Bugs: MESOS-1524
>     https://issues.apache.org/jira/browse/MESOS-1524
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The Docker usage test breaks since we launch a Docker with given resource limits but when we test usage it will get different limits as Docker update changes it afterwards.
> This fix mocks out Docker update and ignore all Update calls so it has the same resource limits.
> 
> 
> Diffs
> -----
> 
>   src/tests/docker_containerizer_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23510/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Re: Review Request 23510: Fix docker usage unit test

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23510/
-----------------------------------------------------------

(Updated July 17, 2014, 6:58 p.m.)


Review request for mesos, Benjamin Hindman and Yifan Gu.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

The Docker usage test breaks since we launch a Docker with given resource limits but when we test usage it will get different limits as Docker update changes it afterwards.
This fix mocks out Docker update and ignore all Update calls so it has the same resource limits.


Diffs
-----

  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23510/diff/


Testing
-------

make check


Thanks,

Timothy Chen


Re: Review Request 23510: Fix docker usage unit test

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23510/
-----------------------------------------------------------

(Updated July 17, 2014, 6:17 p.m.)


Review request for mesos, Benjamin Hindman and Yifan Gu.


Bugs: MESOS-1524
    https://issues.apache.org/jira/browse/MESOS-1524


Repository: mesos-git


Description
-------

The Docker usage test breaks since we launch a Docker with given resource limits but when we test usage it will get different limits as Docker update changes it afterwards.
This fix mocks out Docker update and ignore all Update calls so it has the same resource limits.


Diffs
-----

  src/tests/docker_containerizer_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/23510/diff/


Testing
-------

make check


Thanks,

Timothy Chen