You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Dunning (JIRA)" <ji...@apache.org> on 2011/01/06 02:08:45 UTC
[jira] Created: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
hbase-env.sh over-rides HBASE_OPTS incorrectly.
-----------------------------------------------
Key: HBASE-3423
URL: https://issues.apache.org/jira/browse/HBASE-3423
Project: HBase
Issue Type: Bug
Affects Versions: 0.90.0
Reporter: Ted Dunning
Fix For: 0.90.0
conf/hbase-env.sh has the following line:
export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
This should be
export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-3423.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Thanks for pointing this out Ted.
Committed trivial change to trunk and 0.90 branch.
> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
> Key: HBASE-3423
> URL: https://issues.apache.org/jira/browse/HBASE-3423
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Ted Dunning
> Fix For: 0.90.0, 0.92.0
>
>
> conf/hbase-env.sh has the following line:
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
> export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998913#comment-12998913 ]
Ted Yu commented on HBASE-3423:
-------------------------------
In place of
{code}
# export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError $(figure_gc_opts $HBASE_HEAPSIZE)"
{code}
You can use:
{code}
if [[ $HBASE_OPTS =~ "HeapDumpOnOutOfMemoryError" ]]; then
A='a'
else
export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
fi
{code}
I first reported this issue more than a month ago.
> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
> Key: HBASE-3423
> URL: https://issues.apache.org/jira/browse/HBASE-3423
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Ted Dunning
> Fix For: 0.90.0, 0.92.0
>
>
> conf/hbase-env.sh has the following line:
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
> export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999731#comment-12999731 ]
stack commented on HBASE-3423:
------------------------------
I backed this out because of HBASE-3561
> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
> Key: HBASE-3423
> URL: https://issues.apache.org/jira/browse/HBASE-3423
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Ted Dunning
> Fix For: 0.90.0, 0.92.0
>
>
> conf/hbase-env.sh has the following line:
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
> export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-3423.
--------------------------
Resolution: Fixed
Nah, won't reopen. We have another issue to track undoing this change.
> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
> Key: HBASE-3423
> URL: https://issues.apache.org/jira/browse/HBASE-3423
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Ted Dunning
> Fix For: 0.92.0, 0.90.0
>
>
> conf/hbase-env.sh has the following line:
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
> export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reopened HBASE-3423:
--------------------------
Reopening
> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
> Key: HBASE-3423
> URL: https://issues.apache.org/jira/browse/HBASE-3423
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Ted Dunning
> Fix For: 0.90.0, 0.92.0
>
>
> conf/hbase-env.sh has the following line:
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
> export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978157#action_12978157 ]
Hudson commented on HBASE-3423:
-------------------------------
Integrated in HBase-TRUNK #1705 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1705/])
HBASE-3423 hbase-env.sh overrides HBASE_OPTS incorrectly
> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
> Key: HBASE-3423
> URL: https://issues.apache.org/jira/browse/HBASE-3423
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Ted Dunning
> Fix For: 0.90.0, 0.92.0
>
>
> conf/hbase-env.sh has the following line:
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
> export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998899#comment-12998899 ]
Tim Sell commented on HBASE-3423:
---------------------------------
This caused HBASE-3561, by duplicating options.
Presumably this is needed for some reason, is there some other way to inject OPTIONS that wont cause duplicates?
> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
> Key: HBASE-3423
> URL: https://issues.apache.org/jira/browse/HBASE-3423
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Ted Dunning
> Fix For: 0.90.0, 0.92.0
>
>
> conf/hbase-env.sh has the following line:
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
> export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3423) hbase-env.sh over-rides HBASE_OPTS
incorrectly.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999170#comment-12999170 ]
stack commented on HBASE-3423:
------------------------------
Yeah, this is broke. The hbase-env.sh file is sourced in a few places. Each sourcing will double up HBASE_OPTS when we have this in place. I took a look at hadoop. It sources hadoop-env in hadoop script and in hadoop-daemon. Messing around, this will make for the same tripling when we have HBASE_OPTS defined as value of whatever HBASE_OPTS currently is (HADOOP_OPTS does not have HADOOP_OPTS in its value).
Whats the objective? Being able to get stuff in from the environment? Generally we do all in our power to shut out environment settings so we're not exposed to vagaries of the personality doing a deploy.
> hbase-env.sh over-rides HBASE_OPTS incorrectly.
> -----------------------------------------------
>
> Key: HBASE-3423
> URL: https://issues.apache.org/jira/browse/HBASE-3423
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.0
> Reporter: Ted Dunning
> Fix For: 0.90.0, 0.92.0
>
>
> conf/hbase-env.sh has the following line:
> export HBASE_OPTS="-ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
> This should be
> export HBASE_OPTS="$HBASE_OPTS -ea -XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira