[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6889: Spark 3.3: Skip duplicate check on deleted file path when import files

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #6889:
URL: https://github.com/apache/iceberg/pull/6889#discussion_r1112472215


##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -103,6 +103,35 @@ public void addDataUnpartitioned() {
         sql("SELECT * FROM %s ORDER BY id", tableName));
   }
 
+  @Test
+  public void deleteAndAddBackAllowed() {

Review Comment:
   Nit: on test name, I think 'allowed' is fairly redundant and we can remove it?  I think all of the tests check if what they test is allowed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org