You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Savonitar (via GitHub)" <gi...@apache.org> on 2026/03/26 21:04:19 UTC
[PR] [FLINK-39338] Fix topic name collisions in KafkaWriterTestBase for parameterized tests [flink-connector-kafka]
Savonitar opened a new pull request, #242:
URL: https://github.com/apache/flink-connector-kafka/pull/242
`KafkaWriterTestBase.setUp` derives the topic name from `testInfo.getDisplayName()`, which for parameterized tests does not include the method name. This causes topic name collisions when multiple parameterized test methods use the same enum source (e.g. `testRegisterMetrics` and `testNotRegisterMetrics` both produce topic `1exactlyonce`).
The fix adds the test method name to the beginning, when it is not already part of the display name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39338] Fix topic name collisions in KafkaWriterTestBase for parameterized tests [flink-connector-kafka]
Posted by "Savonitar (via GitHub)" <gi...@apache.org>.
Savonitar commented on PR #242:
URL: https://github.com/apache/flink-connector-kafka/pull/242#issuecomment-4141104359
It is a prerequisite for https://github.com/apache/flink-connector-kafka/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39338] Fix topic name collisions in KafkaWriterTestBase for parameterized tests [flink-connector-kafka]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #242:
URL: https://github.com/apache/flink-connector-kafka/pull/242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39338] Fix topic name collisions in KafkaWriterTestBase for parameterized tests [flink-connector-kafka]
Posted by "Savonitar (via GitHub)" <gi...@apache.org>.
Savonitar commented on PR #242:
URL: https://github.com/apache/flink-connector-kafka/pull/242#issuecomment-4142051782
@1996fanrui thank you for the review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org