[jira] [Commented] (LUCENE-5465) Solr Contrib "map-reduce" breaks Manifest of all other JAR files by adding a broken Main-Class attribute

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908322#comment-13908322 ] 

Uwe Schindler commented on LUCENE-5465:
---------------------------------------

We might fix that issue, but I would completely remove that attribute on the Solr map-reduce contrib's JAR file. The JAR file is not self-contained (means maven-shaded), so you cannot really start it with {{java -jar}}, because the classpath is not complete.

Maybe remove the "main.class" stuff from {{<jarify/>}}?

> Solr Contrib "map-reduce" breaks Manifest of all other JAR files by adding a broken Main-Class attribute
> --------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5465
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5465
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.7
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>
> The addition of the Solr map-reduce contrib created a new "main.class" property, which is used by the jarify task. Currently only the map-reduce plugin actually set this property, soall other generated JAR files contain the following line:
> {{Main-Class: $\{main.class\}}}
> This happens because the ANT property "main.class" is undefined for most modules. Maybe this was added for one of the modules (I assume that the Solr-Morphline JARs use this attribute?). We should add some if/then/else structure to the {{<jarify/>}} task that only sets this property, if it is actually defined. Otherwise remove it (I think ANT does this automatically if its empty, means string-empty, have to try out)
> This leads to an error if the file is double-clicked or started via {{java -jar}}:
> {noformat}
> C:\Users\Uwe Schindler\Desktop>java -jar lucene-core-4.7.0.jar
> Fehler: Hauptklasse ${main.class} konnte nicht gefunden oder geladen werden
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org