You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ggevay <gi...@git.apache.org> on 2015/08/16 15:49:17 UTC
[GitHub] flink pull request: [FLINK-2527] [gelly] Ensure that VertexUpdateF...
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/1027
[FLINK-2527] [gelly] Ensure that VertexUpdateFunction.setNewVertexValue is called at most once
I implemented (1), with the check to enforce that it is called at most once. Unfortunately, I had to add exception specification to a number of methods, and users might also have to do this with already existing code. If you think this does not worth it, then I can remove the check.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ggevay/flink setNewVertexValueFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1027.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1027
----
commit 9b514633d868b28d628785a0d099115134599cee
Author: Gabor Gevay <gg...@gmail.com>
Date: 2015-08-16T13:26:59Z
[FLINK-2527] [gelly] Ensure that VertexUpdateFunction.setNewVertexValue is called at most once per updateVertex
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2527] [gelly] Ensure that VertexUpdateF...
Posted by ggevay <gi...@git.apache.org>.
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1027#issuecomment-131612652
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2527] [gelly] Ensure that VertexUpdateF...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1027#issuecomment-131576936
I think you can make this non-API-breaking by simply throwing an `IllegalStateException`, which is a `RuntimeException` and therefore needs no part in the signature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2527] [gelly] Ensure that VertexUpdateF...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1027#issuecomment-131753704
Looks good, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2527] [gelly] Ensure that VertexUpdateF...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1027
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---