You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/09 09:05:37 UTC

[GitHub] [pulsar] RobertIndie opened a new pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

RobertIndie opened a new pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227


   ### Motivation
   In setting autoUpdatePartitionsInterval, just on the first call to partitionsAutoUpdateTimerTask were set up. But the next recheck schedule is still using the default parameters. This PR fixes the problem.
   
   ### Modifications
   
   * Set timeout delay for partitionsAutoUpdateTimerTask recheck schedule
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] wolfstudy commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-717852033


   @RobertIndie Can you help to check test case of `testPulsarFunctionBKCleanup`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] wolfstudy commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-716952560


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] RobertIndie commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-706175912


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] RobertIndie commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-706109668






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] RobertIndie commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-719357789


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] RobertIndie commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-706462071


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] wolfstudy commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-716979719


   ```
   Error:  Tests run: 3, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 68.687 s <<< FAILURE! - in org.apache.pulsar.functions.worker.PulsarFunctionPublishTest
   Error:  testPulsarFunctionBKCleanup(org.apache.pulsar.functions.worker.PulsarFunctionPublishTest)  Time elapsed: 20.043 s  <<< FAILURE!
   org.testng.internal.thread.ThreadTimeoutException: Method org.apache.pulsar.functions.worker.PulsarFunctionPublishTest.testPulsarFunctionBKCleanup() didn't finish within the time-out 20000
   ```
   
   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] RobertIndie commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-706703665


   /pulsarbot run-failure-checks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] RobertIndie commented on pull request #8227: [Client]Fix AutoUpdatePartitionsInterval setting problem

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #8227:
URL: https://github.com/apache/pulsar/pull/8227#issuecomment-706109668


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org