You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mwkang <gi...@git.apache.org> on 2015/12/01 10:23:15 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-358: Jetty server is HTT...
GitHub user mwkang opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/498
ZEPPELIN-358: Jetty server is HTTP ERROR 404
Define local jetty temp directory.
`varName: zeppelin.war.tempdir`
`default varValue: webapps`
Zeppelin create temp directory in `{zeppelin.home}/webapps` when zeppelin server start.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/498.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #498
----
commit 98b784c108a578e6822800705c1f945b481622ce
Author: Minwoo Kang <mi...@outlook.com>
Date: 2015-12-01T06:57:24Z
ZEPPELIN-358 add jetty temporary directory
commit 0046d36079a5fe536d234716d7435bfadabe6b92
Author: Minwoo Kang <mi...@outlook.com>
Date: 2015-12-01T08:58:49Z
ZEPPELIN-358 use getRelativeDir instead of getString
commit cc7fdb71538953c254e09fdcc1d6d697c7ff80a9
Author: Minwoo Kang <mi...@outlook.com>
Date: 2015-12-01T09:11:57Z
ZEPPELIN-358 restore unused imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-358: Jetty server is HTT...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/498#issuecomment-161157232
Thanks. I have tested. works nicely and got this log
```
INFO [2015-12-02 11:06:22,383] ({main} WebInfConfiguration.java[unpack]:478) - Extract jar:file:/zeppelin-0.6.0-incubating-SNAPSHOT/zeppelin-web-0.6.0-incubating-SNAPSHOT.war!/ to /zeppelin-0.6.0-incubating-SNAPSHOT/webapps/webapp
```
Looks good to me.
One minor thing is, do you mind add the environment variable to
https://github.com/apache/incubator-zeppelin/blob/master/conf/zeppelin-env.sh.template#L27
and the property to
https://github.com/apache/incubator-zeppelin/blob/master/conf/zeppelin-site.xml.template
and update documentation
https://github.com/apache/incubator-zeppelin/blob/master/docs/install/install.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-358: Jetty server is HTT...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/498#issuecomment-161828768
Looks great to me, merging if there are no other discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-358: Jetty server is HTT...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/498#issuecomment-161157672
Thanks for your review.
I update the documents.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-358: Jetty server is HTT...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/498#issuecomment-161175482
Thanks for the contribution.
Looks good to me and merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-358: Jetty server is HTT...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/498
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-358: Jetty server is HTT...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/498#issuecomment-161161076
I update the documents.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---