You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/13 10:34:27 UTC

[GitHub] [doris] morningman opened a new pull request, #13354: [feature-wip](new-scan) Support stream load with csv in new scan framework

morningman opened a new pull request, #13354:
URL: https://github.com/apache/doris/pull/13354

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   1. Refactor the file reader creation in FileFactory, for simplicity.
       Previously, FileFactory had too many `create_file_reader` interfaces.
       Now unified into two categories: the interface used by the previous BrokerScanNode,
       and the interface used by the new FileScanNode.
       And separate the creation methods of readers that read `StreamLoadPipe` and other readers that read files.
   
   2. Modifyt the StreamLoadPlanner on FE side to support using ExternalFileScanNode
   
   3. Now for generic reader, the file reader will be created inside the reader, not passed from the outside.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   4. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   5. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   6. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   7. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #13354: [feature-wip](new-scan) Support stream load with csv in new scan framework

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13354:
URL: https://github.com/apache/doris/pull/13354#issuecomment-1279868419

   https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221016093707_clickbench_pr_29833.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #13354: [feature-wip](new-scan) Support stream load with csv in new scan framework

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13354:
URL: https://github.com/apache/doris/pull/13354#issuecomment-1279649589

   https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221015115158_clickbench_pr_29717.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #13354: [feature-wip](new-scan) Support stream load with csv in new scan framework

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13354:
URL: https://github.com/apache/doris/pull/13354#issuecomment-1279809343

   https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221016025825_clickbench_pr_29807.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] morningman merged pull request #13354: [feature-wip](new-scan) Support stream load with csv in new scan framework

Posted by GitBox <gi...@apache.org>.
morningman merged PR #13354:
URL: https://github.com/apache/doris/pull/13354


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org