You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jbonofre <gi...@git.apache.org> on 2017/06/29 12:28:50 UTC

[GitHub] beam pull request #3471: Define the projectId in the SpannerIO Read Test (ut...

GitHub user jbonofre opened a pull request:

    https://github.com/apache/beam/pull/3471

    Define the projectId in the SpannerIO Read Test (utest, not itest)

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    It fixes issue on `SpannerIO` test (not itest) saying the `projectId` is not defined and precondition fails.
    
    R: @kennknowles 
    CC: @mairbek 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/beam SPANNERIO_READ_TEST_FIX

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3471.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3471
    
----
commit 47fa2b7f099f3177787ec4280502effaa72ff600
Author: Jean-Baptiste Onofré <jb...@apache.org>
Date:   2017-06-29T11:25:36Z

    Define the projectId in the SpannerIO Read Test (utest, not itest)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3471: Define the projectId in the SpannerIO Read Test (ut...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3471


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---