[jira] [Commented] (HAMA-857) Graph Combiners is wrongly implemented

["Edward J. Yoon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAMA-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878167#comment-13878167 ] 

Edward J. Yoon commented on HAMA-857:
-------------------------------------

Like OutgoingPOJOMessageBundle, we should add outgoing vertex messages manager for this issue. 

To reduce the communication load, vertex messages should be combined in there.



> Graph Combiners is wrongly implemented
> --------------------------------------
>
>                 Key: HAMA-857
>                 URL: https://issues.apache.org/jira/browse/HAMA-857
>             Project: Hama
>          Issue Type: Bug
>          Components: graph
>    Affects Versions: 0.6.3
>            Reporter: Edward J. Yoon
>            Priority: Critical
>             Fix For: 0.7.0
>
>
> Current implementation combines the already received messages.
> {code}
>           if (combiner != null) {
>             M combined = combiner.combine(iterable);
>             vertex.compute(Collections.singleton(combined));
>           } else {
>             vertex.compute(iterable);
>           }
> {code}
> Messages should be combined before sending to another vertex.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)