You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "ggbdpq (via GitHub)" <gi...@apache.org> on 2026/09/01 23:00:13 UTC
[PR] fix(desktop): load desktop stories on Windows with a config-relative glob [maka]
ggbdpq opened a new pull request, #4517:
URL: https://github.com/apache/maka/pull/4517
## Summary
- On Windows, Storybook in `apps/desktop` silently indexed only `packages/ui/stories` (53 entries, zero desktop story files): the desktop stories glob was built with `resolve(REPO_ROOT, ...)`, handing the globber a backslash absolute path, and glob matchers treat backslashes as escape characters (#4516).
- The desktop glob now uses the same forward-slash config-relative form the neighboring `packages/ui` entry already uses (`'../stories/**/*.stories.@(ts|tsx)'`), so it resolves against the config dir on every platform.
## Verification
| Claim | Command | Result |
| --- | --- | --- |
| Desktop stories load on Windows | `npm run storybook` (apps/desktop), then fetch `http://localhost:6006/index.json` | Before: 53 entries, no `product-agent-graph--*` / `product-onboarding-*` / etc. After: 251 entries including all 11 desktop story files; the Product/Agent Graph stories render and play |
| Linux behavior unchanged | - | Relative globs resolve against the config dir on both platforms; the packages/ui entry has always used this form |
| Repo format | `npm run format:check` | Checked 1854 files, no issues |
| ASF headers | `npm run check:asf-headers` | Every source file carries the ASF header or a reviewed exclusion |
## AI use
Analysis and the fix were produced with GLM-5.3-Flash (ZCode) under the contributor's direction; the contributor reviewed and is the human contributor of record.
## Checklist
- [x] Tests and checks pass locally (see Verification)
- [ ] Behavior change: **No** - config-only fix; Storybook story discovery on Linux is unchanged, on Windows it goes from broken to working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): load desktop stories on Windows with a config-relative glob [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #4517:
URL: https://github.com/apache/maka/pull/4517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org