[GitHub] [incubator-superset] villebro commented on a change in pull request #8693: [jinja_context] Fix, allow for app factory pattern

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8693: [jinja_context] Fix, allow for app factory pattern
URL: https://github.com/apache/incubator-superset/pull/8693#discussion_r352177792
 
 

 ##########
 File path: docs/sqllab.rst
 ##########
 @@ -112,11 +112,11 @@ of queries before executing this. Currently, Presto is supported in SQL Lab. To
 enable query cost estimation, add the following keys to the "Extra" field in the
 database configuration:
 
-.. code-block:: json
+.. code-block:: text
 
     {
         "version": "0.319",
-        "cost_estimate_enabled": true,
+        "cost_estimate_enabled": true
 
 Review comment:
   Isn't `json` supported in the current version? According to this it should've been included for quite some time:
   
   https://stackoverflow.com/questions/4259105/which-sphinx-code-block-language-to-use-for-json

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org