Re: [PR] [feat][misc] PIP-320: Add OpenTelemetry scaffolding [pulsar]

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on code in PR #22010:
URL: https://github.com/apache/pulsar/pull/22010#discussion_r1473654253


##########
pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionAssignmentTailerTest.java:
##########
@@ -71,6 +73,7 @@ public void testErrorNotifier() throws Exception {
         workerConfig.setPulsarServiceUrl("pulsar://localhost:6650");
         workerConfig.setStateStorageServiceUrl("foo");
         workerConfig.setFunctionAssignmentTopicName("assignments");
+        workerConfig.setPulsarFunctionsCluster(CLUSTER_NAME);

Review Comment:
   Would this throw exception in the OTel provider if we don't pass a cluster name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org