You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jgiannuzzi (via GitHub)" <gi...@apache.org> on 2025/10/10 14:47:42 UTC
[PR] [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
jgiannuzzi opened a new pull request, #47779:
URL: https://github.com/apache/arrow/pull/47779
### Rationale for this change
This change enables building Arrow C++ for Windows ARM64 with MSVC when setting `ARROW_SIMD_LEVEL` to `NONE`. This is useful to be able to build Arrow with `vcpkg` and use it as a dependency.
Setting `ARROW_SIMD_LEVEL` to `NONE` is done to disable the use of `xsimd`, which does not yet support msvc arm64 intrinsics, and is non-trivial to fix.
### What changes are included in this PR?
A patch to the vendored `pcg` library, based on https://github.com/imneme/pcg-cpp/pull/99. The upstream pcg library has not been updated in the past 3 years, so this may never get merged.
### Are these changes tested?
Yes, the changes have been tested in https://github.com/microsoft/vcpkg/pull/47750 (the same patch for `vcpkg`, which this change would alleviate) and in https://github.com/jgiannuzzi/ParquetSharp/actions/runs/18354286294 (a full run of the ParquetSharp CI, using this patch to build Arrow with `vcpkg`).
### Are there any user-facing changes?
Not really, unless you consider adding the ability to build Arrow on Windows ARM64 user-facing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3406978737
CI failures are unrelated, I'll merge. Thank you @jgiannuzzi !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3393270826
> Setting `ARROW_SIMD_LEVEL` to `NONE` is done to disable the use of `xsimd`, which does not yet support msvc arm64 intrinsics, and is non-trivial to fix.
@JohanMabille @AntoinePrv @serge-sans-paille Do you think xsimd can support ARM64 intrinsics on MSVC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3396502783
> we still support C++11
Really? I think that we require C++17: https://github.com/apache/arrow/blob/81ef967e8e35f98f6e09c194c9417cefb5193ac8/cpp/cmake_modules/SetupCxxFlags.cmake#L142-L147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3396303936
> I understand to you may not want to rely on such a small/unknown repo, but I'm happy to address your concerns and make further improvements where needed.
Well, I think we could at some point. For now, we still support C++11 so we'll have to patch our vendored copy instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "JohanMabille (via GitHub)" <gi...@apache.org>.
JohanMabille commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3396196864
> > Setting `ARROW_SIMD_LEVEL` to `NONE` is done to disable the use of `xsimd`, which does not yet support msvc arm64 intrinsics, and is non-trivial to fix.
>
> @JohanMabille @AntoinePrv @serge-sans-paille Do you think xsimd can support ARM64 intrinsics on MSVC?
Yes it could, but I cannot give a deadline for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "jgiannuzzi (via GitHub)" <gi...@apache.org>.
jgiannuzzi commented on code in PR #47779:
URL: https://github.com/apache/arrow/pull/47779#discussion_r2432711401
##########
cpp/src/arrow/vendored/pcg/README.md:
##########
@@ -25,4 +25,5 @@ Sources are taken from git changeset ffd522e7188bef30a00c74dc7eb9de5faff90092
Changes:
- enclosed in `arrow_vendored` namespace
- remove `struct arbitrary_seed` definition because of https://github.com/apache/arrow/issues/35596
+- enable MSVC ARM64 intrinsics to allow building on Windows ARM64 with Visual Studio
Review Comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "jgiannuzzi (via GitHub)" <gi...@apache.org>.
jgiannuzzi commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3406988409
Thanks @pitrou!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #47779:
URL: https://github.com/apache/arrow/pull/47779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "brt-v (via GitHub)" <gi...@apache.org>.
brt-v commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3394115906
> > Hmm. It seems that https://github.com/imneme/pcg-cpp isn't maintained...
> > Do we have alternative implementation...?
>
> There is a fork here by @brt-v: https://github.com/brt-v/pcg-cpp?tab=readme-ov-file#about-this-fork I'm not sure how reasonable it is to rely on it, though.
I made that fork because of the lack of maintenance of the original implementation, with mostly quality of life improvements. The logic and tests are identical to the original, excepts for some small fixes to get all tests working on Windows. Note that I'm not an rng researcher and have no intention in further developing the algorithm, I just wanted to provide an easy to use library. I understand to you may not want to rely on such a small/unknown repo, but I'm happy to address your concerns and make further improvements where needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3406236447
@github-actions crossbow submit -g cpp *win*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "jgiannuzzi (via GitHub)" <gi...@apache.org>.
jgiannuzzi commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3393597461
> What does this patch have to do with xsimd? Am I missing something?
Sorry @pitrou, my description wasn't clear. This patch has nothing to do with `xsimd`. I just meant to say that this `pcg` patch is not enough to build arrow with `msvc` on arm64 - you also need to set `ARROW_SIMD_LEVEL` to `NONE` because otherwise `xsimd` doesn't build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "jgiannuzzi (via GitHub)" <gi...@apache.org>.
jgiannuzzi commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3405344920
This PR adds a CI job to build the C++ library with msvc arm64: https://github.com/apache/arrow/pull/47811. I left it as draft as it depends on this current PR to be merged first. @pitrou what are your latest thoughts on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3408229360
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 541cba859c3cdb4cc6cb3f456aaae79f67c7d57d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/52852521882) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47779:
URL: https://github.com/apache/arrow/pull/47779#discussion_r2432705643
##########
cpp/src/arrow/vendored/pcg/README.md:
##########
@@ -25,4 +25,5 @@ Sources are taken from git changeset ffd522e7188bef30a00c74dc7eb9de5faff90092
Changes:
- enclosed in `arrow_vendored` namespace
- remove `struct arbitrary_seed` definition because of https://github.com/apache/arrow/issues/35596
+- enable MSVC ARM64 intrinsics to allow building on Windows ARM64 with Visual Studio
Review Comment:
Or just link to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #47779:
URL: https://github.com/apache/arrow/pull/47779#discussion_r2432703501
##########
cpp/src/arrow/vendored/pcg/README.md:
##########
@@ -25,4 +25,5 @@ Sources are taken from git changeset ffd522e7188bef30a00c74dc7eb9de5faff90092
Changes:
- enclosed in `arrow_vendored` namespace
- remove `struct arbitrary_seed` definition because of https://github.com/apache/arrow/issues/35596
+- enable MSVC ARM64 intrinsics to allow building on Windows ARM64 with Visual Studio
Review Comment:
Can you add the actual patch too, so that we can re-apply it easily?
Something like:
````suggestion
- enable MSVC ARM64 intrinsics to allow building on Windows ARM64 with Visual Studio:
```patch
diff --git a/cpp/src/arrow/vendored/pcg/pcg_uint128.hpp b/cpp/src/arrow/vendored/pcg/pcg_uint128.hpp
index 0181e69e4ef..012f3d66823 100644
--- a/cpp/src/arrow/vendored/pcg/pcg_uint128.hpp
+++ b/cpp/src/arrow/vendored/pcg/pcg_uint128.hpp
@@ -67,7 +67,7 @@
#define PCG_LITTLE_ENDIAN 1
#elif __BIG_ENDIAN__ || _BIG_ENDIAN
#define PCG_LITTLE_ENDIAN 0
- #elif __x86_64 || __x86_64__ || _M_X64 || __i386 || __i386__ || _M_IX86
+ #elif __x86_64 || __x86_64__ || _M_X64 || __i386 || __i386__ || _M_IX86 || _M_ARM64
#define PCG_LITTLE_ENDIAN 1
#elif __powerpc__ || __POWERPC__ || __ppc__ || __PPC__ \
|| __m68k__ || __mc68000__
@@ -734,7 +734,13 @@ uint_x4<UInt,UIntX2> operator*(const uint_x4<UInt,UIntX2>& a,
#if PCG_64BIT_SPECIALIZATIONS
#if defined(_MSC_VER)
+#if defined(_M_X64) || defined(_M_IX86)
#pragma intrinsic(_umul128)
+#elif defined(_M_ARM64)
+#pragma intrinsic(__umulh)
+#else
+#error Unsupported architecture
+#endif
#endif
#if defined(_MSC_VER) || __SIZEOF_INT128__
@@ -743,8 +749,15 @@ uint_x4<UInt32,uint64_t> operator*(const uint_x4<UInt32,uint64_t>& a,
const uint_x4<UInt32,uint64_t>& b)
{
#if defined(_MSC_VER)
+#if defined(_M_X64) || defined(_M_IX86)
uint64_t hi;
uint64_t lo = _umul128(a.d.v01, b.d.v01, &hi);
+#elif defined(_M_ARM64)
+ uint64_t lo = a.d.v01 * b.d.v01;
+ uint64_t hi = __umulh(a.d.v01, b.d.v01);
+#else
+#error Unsupported architecture
+#endif
#else
__uint128_t r = __uint128_t(a.d.v01) * __uint128_t(b.d.v01);
uint64_t lo = uint64_t(r);
```
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3393238782
Hmm. It seems that https://github.com/imneme/pcg-cpp isn't maintained...
Do we have alternative implementation...?
https://github.com/imneme/pcg-cpp was vendored by #8879. @pitrou Do you have any opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3393272646
> A patch to the vendored `pcg` library, based on [imneme/pcg-cpp#99](https://github.com/imneme/pcg-cpp/pull/99). The upstream pcg library has not been updated in the past 3 years, so this may never get merged.
What does this patch have to do with xsimd? Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3391435150
:warning: GitHub issue #47784 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "jgiannuzzi (via GitHub)" <gi...@apache.org>.
jgiannuzzi commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3394013135
> @JohanMabille @AntoinePrv @serge-sans-paille Do you think xsimd can support ARM64 intrinsics on MSVC?
I found this PR created in 2021 attempting to solve this: https://github.com/xtensor-stack/xsimd/pull/612.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3396525777
> Really? I think that we require C++17:
Wow. I even did the change myself. Clearly I haven't drunk enough tea this morning...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3390572404
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3394056115
> Hmm. It seems that https://github.com/imneme/pcg-cpp isn't maintained...
>
> Do we have alternative implementation...?
There is a fork here by @brt-v: https://github.com/brt-v/pcg-cpp?tab=readme-ov-file#about-this-fork
I'm not sure how reasonable it is to rely on it, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3406251051
Revision: d6c980c70556db93ef047a62e6b9597a08ed904c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c9b3535f37](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c9b3535f37)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317371/job/52807657838)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317448/job/52807658095)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317055/job/52807656765)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317389/job/52807657797)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317912/job/52807660004)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317131/job/52807656904)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317341/job/52807657649)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318424/job/52807661278)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317397/job/52807657774)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317780/job/52807659209)|
|test-fedora-42-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318476/job/52807661206)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317519/job/52807658056)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317011/job/52807656967)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318006/job/52807661120)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317794/job/52807659076)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318096/job/52807660445)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317994/job/52807659842)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317980/job/52807661641)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318592/job/52807661531)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317871/job/52807659498)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318163/job/52807660186)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317940/job/52807659605)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/18529316879/job/52807656611)|
|wheel-windows-cp310-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317205/job/52807657228)|
|wheel-windows-cp311-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318318/job/52807661266)|
|wheel-windows-cp312-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317073/job/52807656934)|
|wheel-windows-cp313-cp313-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318619/job/52807661720)|
|wheel-windows-cp313-cp313t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317884/job/52807659556)|
|wheel-windows-cp314-cp314-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/18529318179/job/52807660406)|
|wheel-windows-cp314-cp314t-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/18529317663/job/52807659100)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47784: [C++] Patch vendored pcg library to enable msvc arm64 intrinsics [arrow]
Posted by "jgiannuzzi (via GitHub)" <gi...@apache.org>.
jgiannuzzi commented on PR #47779:
URL: https://github.com/apache/arrow/pull/47779#issuecomment-3406435244
> Please update the [`README`](https://github.com/apache/arrow/blob/a53ebde62053a6fc791fc7d8a8280167d5f3fda7/cpp/src/arrow/vendored/pcg/README.md#L4) to include the patch that was applied, otherwise LGTM.
Done! Could you please review again @pitrou?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org