You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Thejas M Nair (JIRA)" <ji...@apache.org> on 2009/07/10 22:11:14 UTC

[jira] Created: (PIG-882) log level not propogated to loggers

log level not propogated to loggers 
------------------------------------

                 Key: PIG-882
                 URL: https://issues.apache.org/jira/browse/PIG-882
             Project: Pig
          Issue Type: Bug
          Components: impl
            Reporter: Thejas M Nair


Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai reassigned PIG-882:
------------------------------

    Assignee: Daniel Dai

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Status: In Progress  (was: Patch Available)

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Attachment: PIG-882-4.patch

Sync with latest trunk

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-882) log level not propogated to loggers

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754219#action_12754219 ] 

Olga Natkovich commented on PIG-882:
------------------------------------

+1

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: duplicate_message.patch, PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Attachment: duplicate_message.patch

Previous patch introduce a duplicate error message problem. The cause of the problem is that we set the org.apache.pig to use appender PIGCONSOLE, but do not change the root logger. Log4j think that root logger is using a default appender and org.apache.pig is using PIGCONSOLE. So the message is printed out twice to the default appender and PIGCONSOLE. 

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: duplicate_message.patch, PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-882) log level not propogated to loggers

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737006#action_12737006 ] 

Hadoop QA commented on PIG-882:
-------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12414928/PIG-882-4.patch
  against trunk revision 799141.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to cause Findbugs to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/145/testReport/
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/145/console

This message is automatically generated.

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

All unit tests passed. Hudson do not respond, committed patch anyway.

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Attachment: PIG-882-3.patch

Modify patch according to Santhosh's suggestion.

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Status: Patch Available  (was: Open)

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Attachment: PIG-882-1.patch

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Status: Patch Available  (was: Reopened)

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: duplicate_message.patch, PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

       Resolution: Fixed
    Fix Version/s: 0.4.0
           Status: Resolved  (was: Patch Available)

I don't have a unit test case for the same reason of the first patch. See my first comment.

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: duplicate_message.patch, PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Status: Patch Available  (was: Open)

Pick me up, Hudson!

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

        Fix Version/s: 0.4.0
    Affects Version/s: 0.3.0
               Status: Patch Available  (was: In Progress)

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Status: Open  (was: Patch Available)

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736365#action_12736365 ] 

Daniel Dai commented on PIG-882:
--------------------------------

Some comments about how to use debug level:
1. conf/log4j.properties is not used by default, if you want to use it, you need explicitly say: -4 conf/log4j.properties
2. -d DEBUG and -b works as desired
3. Only log level will propogate to backend, all logs appear in hadoop syslog, no matter what you put into log4j.properties. Hadoop have its own mechanism for all backend logging, Pig only override log level for Pig logs.

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Attachment: PIG-882-2.patch

New patch propagates pig log level to backend. I do not find a good way to write a unit test especially for the backend part so no unit test was added,

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai reopened PIG-882:
----------------------------


> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-882) log level not propogated to loggers

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738972#action_12738972 ] 

Hudson commented on PIG-882:
----------------------------

Integrated in Pig-trunk #512 (See [http://hudson.zones.apache.org/hudson/job/Pig-trunk/512/])
    : log level not propogated to loggers


> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-882) log level not propogated to loggers

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754015#action_12754015 ] 

Hadoop QA commented on PIG-882:
-------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12419249/duplicate_message.patch
  against trunk revision 813601.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/4/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/4/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/4/console

This message is automatically generated.

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: duplicate_message.patch, PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PIG-882) log level not propogated to loggers

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-882:
---------------------------

    Attachment: PIG-882-5.patch

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-882) log level not propogated to loggers

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753958#action_12753958 ] 

Hadoop QA commented on PIG-882:
-------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12419249/duplicate_message.patch
  against trunk revision 813601.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/3/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/3/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/3/console

This message is automatically generated.

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Thejas M Nair
>            Assignee: Daniel Dai
>             Fix For: 0.4.0
>
>         Attachments: duplicate_message.patch, PIG-882-1.patch, PIG-882-2.patch, PIG-882-3.patch, PIG-882-4.patch, PIG-882-5.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (PIG-882) log level not propogated to loggers

Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736359#action_12736359 ] 

Santhosh Srinivasan commented on PIG-882:
-----------------------------------------

Minor comment:

Index: src/org/apache/pig/Main.java
===================================================================

Instead of printing the warning message to stdout, it should be printed to stderr.

{code}
+        catch (IOException e)
+        {
+            System.out.println("Warn: Cannot open log4j properties file, use default");
+        }
{code}


The rest of the patch looks fine.

> log level not propogated to loggers 
> ------------------------------------
>
>                 Key: PIG-882
>                 URL: https://issues.apache.org/jira/browse/PIG-882
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Thejas M Nair
>         Attachments: PIG-882-1.patch, PIG-882-2.patch
>
>
> Pig accepts log level as a parameter. But the log level it captures is not set appropriately, so that loggers in different classes log at the specified level.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.