You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 14:08:19 UTC
[GitHub] [airflow] potiuk opened a new pull request #21463: Addd deleting orphans on cascade for permission model
potiuk opened a new pull request #21463:
URL: https://github.com/apache/airflow/pull/21463
Apparently, sync_roles script might lead to leaving orphan
rows during syncing the permission model. Since the permission
model is only used as "static" model mostly, making sure that
there are no orphans left via modifying the cascade method seems
to be a good solution - it might lead to deletion and recration
of rows so we cannot track/audit changes easily but in case of
syncing it seems to be not really needed.
Based on discussion in
https://stackoverflow.com/questions/23699651/dependency-rule-tried-to-blank-out-primary-key-in-sqlalchemy-when-foreign-key-c
Probably Fixes: #21407
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #21463: Addd deleting orphans on cascade for permission model
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #21463:
URL: https://github.com/apache/airflow/pull/21463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21463: Addd deleting orphans on cascade for permission model
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21463:
URL: https://github.com/apache/airflow/pull/21463#issuecomment-1033807111
As discussed in #21407 - I have no firm idea if what I am doing is good solution (yet) - but that might be a fix to the docker-compose problems so I am trying it out to see if this helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21463: Addd deleting orphans on cascade for permission model
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21463:
URL: https://github.com/apache/airflow/pull/21463#issuecomment-1033852914
Closing as I truly did not know what I was doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org