You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Bas Harenslak (JIRA)" <ji...@apache.org> on 2019/06/02 18:58:00 UTC
[jira] [Updated] (AIRFLOW-4364) Integrate Pylint
[ https://issues.apache.org/jira/browse/AIRFLOW-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bas Harenslak updated AIRFLOW-4364:
-----------------------------------
Description:
After a [vote on the mailing list|https://lists.apache.org/thread.html/f4940d36e98ded96a2473bb2ccdfa4cc648faa2c1334b2aa901c0bba@%3Cdev.airflow.apache.org%3E] everybody voted for pylint integration.
Making the whole project Pylint compatible is a lot of work and big change. Therefore we split up all the work in subissues under this issue. The approach is as follows:
All files are currently blacklisted from Pylint. The blacklist is stored in scripts/ci/pylint_todo.txt. Every subissue relates to one or more files on the blacklist. Once you start on an issue:
# (running scripts/ci/ci_pylint.sh on master should produce no messages)
# Remove the files mentioned in your issue from the blacklist
# Run scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted files
# Fix all messages and create PR
*Why a separate blacklist file and not use Pylint's --ignore-pattern to ignore files?*
--ignore-pattern only works on base filenames, not paths.
*Why don't you blacklist patterns, where 1 line relates to 1 JIRA issue?*
Creating a list of non-overlapping patterns proved difficult, this was the pragmatic solution.
*Rule X is too strict. Can we disable it?*
dsT
was:
After a [vote on the mailing list|https://lists.apache.org/thread.html/f4940d36e98ded96a2473bb2ccdfa4cc648faa2c1334b2aa901c0bba@%3Cdev.airflow.apache.org%3E] everybody voted for pylint integration.
Making the whole project Pylint compatible is a lot of work and big change. Therefore we split up all the work in subissues under this issue. The approach is as follows:
All files are currently blacklisted from Pylint. The blacklist is stored in scripts/ci/pylint_todo.txt. Every subissue relates to one or more files on the blacklist. Once you start on an issue:
# (running scripts/ci/ci_pylint.sh on master should produce no messages)
# Remove the files mentioned in your issue from the blacklist
# Run scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted files
# Fix all messages and create PR
*Why a separate blacklist file and not use Pylint's --ignore-pattern to ignore files?*
--ignore-pattern only works on base filenames, not paths.
*Why don't you blacklist patterns, where 1 line relates to 1 JIRA issue?*
Creating a list of non-overlapping patterns proved difficult, this was the pragmatic solution.
> Integrate Pylint
> ----------------
>
> Key: AIRFLOW-4364
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4364
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ci
> Affects Versions: 2.0.0
> Reporter: Bas Harenslak
> Priority: Major
>
> After a [vote on the mailing list|https://lists.apache.org/thread.html/f4940d36e98ded96a2473bb2ccdfa4cc648faa2c1334b2aa901c0bba@%3Cdev.airflow.apache.org%3E] everybody voted for pylint integration.
> Making the whole project Pylint compatible is a lot of work and big change. Therefore we split up all the work in subissues under this issue. The approach is as follows:
> All files are currently blacklisted from Pylint. The blacklist is stored in scripts/ci/pylint_todo.txt. Every subissue relates to one or more files on the blacklist. Once you start on an issue:
> # (running scripts/ci/ci_pylint.sh on master should produce no messages)
> # Remove the files mentioned in your issue from the blacklist
> # Run scripts/ci/ci_pylint.sh to see all messages on the no longer blacklisted files
> # Fix all messages and create PR
> *Why a separate blacklist file and not use Pylint's --ignore-pattern to ignore files?*
> --ignore-pattern only works on base filenames, not paths.
> *Why don't you blacklist patterns, where 1 line relates to 1 JIRA issue?*
> Creating a list of non-overlapping patterns proved difficult, this was the pragmatic solution.
> *Rule X is too strict. Can we disable it?*
> dsT
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)