[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8164: [wip] More detailed async error messages for sqllab

[GitBox <gi...@apache.org>]

serenajiang commented on a change in pull request #8164: [wip] More detailed async error messages for sqllab
URL: https://github.com/apache/incubator-superset/pull/8164#discussion_r321514513
 
 

 ##########
 File path: superset/db_engine_specs/base.py
 ##########
 @@ -476,7 +476,11 @@ def handle_cursor(cls, cursor, query, session):
         pass
 
     @classmethod
-    def extract_error_message(cls, e: Exception) -> str:
+    def extract_error_message(cls, e: Exception):
 
 Review comment:
   I added a return type for `extract_error_message` but left all the private `_extract_error_message`s without a return type. Mostly because I wanted to avoid putting in a `# noqa` (ugh dict.get). But also, since `extract_error_message` string formats the result of `_extract_error_message`, the return type of `_extract_error_message` shouldn't matter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org