[GitHub] [incubator-superset] villebro commented on a change in pull request #10412: fix: show label for filters in filter box in explore

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10412:
URL: https://github.com/apache/incubator-superset/pull/10412#discussion_r462505739



##########
File path: superset-frontend/spec/javascripts/explore/components/FilterBoxItemControl_spec.jsx
##########
@@ -26,7 +26,9 @@ import FilterBoxItemControl from 'src/explore/components/controls/FilterBoxItemC
 import FormRow from 'src/components/FormRow';
 import datasources from '../../../fixtures/mockDatasource';
 
+const TEST_LABEL = 'some label';
 const defaultProps = {
+  label: TEST_LABEL,

Review comment:
       As `TEST_LABEL` isn't being used anywhere else, I don't see a reason create a `const` for it.
   ```suggestion
   const defaultProps = {
     label:  'some label',
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org